improve benchmarks

make benchmarks even more stable
nit benchmarks
2025-02-18 09:51:21 +01:00 · 2025-02-18 08:43:03 +01:00 · 2025-02-18 01:54:14 +01:00 · 2025-02-18 00:55:01 +01:00 · 2025-02-17 23:57:38 +01:00 · 2025-02-17 22:44:26 +01:00
45 changed files with 355 additions and 171 deletions
--- a/.github/workflows/benchmark.yml
+++ b/.github/workflows/benchmark.yml
@@ -162,6 +162,7 @@ jobs:
          -c
          https://raw.githubusercontent.com/windmill-labs/windmill/${GITHUB_REF##ref/head/}/benchmarks/suite_config.json
          --workers 4
+          --factor 3
      - name: Save benchmark results
        uses: actions/upload-artifact@v4
        with:
@@ -281,6 +282,7 @@ jobs:
          -c
          https://raw.githubusercontent.com/windmill-labs/windmill/${GITHUB_REF##ref/head/}/benchmarks/suite_config.json
          --workers 8
+          --factor 3
      - name: Save benchmark results
        uses: actions/upload-artifact@v4
        with:
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,20 @@
 # Changelog

+## [1.463.4](https://github.com/windmill-labs/windmill/compare/v1.463.3...v1.463.4) (2025-02-17)
+
+
+### Bug Fixes
+
+* improve queue job indices for faster performances ([9530826](https://github.com/windmill-labs/windmill/commit/953082681e2c4fd71d5ac1acf372265ccc72297b))
+* improve teams settings in workspace settings ([#5316](https://github.com/windmill-labs/windmill/issues/5316)) ([935b5b7](https://github.com/windmill-labs/windmill/commit/935b5b799636c0f02597315837268d4a76f6709a))
+
+## [1.463.3](https://github.com/windmill-labs/windmill/compare/v1.463.2...v1.463.3) (2025-02-17)
+
+
+### Bug Fixes
+
+* windmill_admin has implicit bypass rls on v2_job even if role not set ([0208f53](https://github.com/windmill-labs/windmill/commit/0208f53541473aa51bed0e15d938def3d4530e3f))
+
 ## [1.463.2](https://github.com/windmill-labs/windmill/compare/v1.463.1...v1.463.2) (2025-02-16)


--- a/backend/.sqlx/query-0cb0e912bc942af2b1ef784455f3f073a79e300f3dd48f14122d1782eee663cd.json
+++ b/backend/.sqlx/query-0cb0e912bc942af2b1ef784455f3f073a79e300f3dd48f14122d1782eee663cd.json
@@ -1,6 +1,6 @@
 {
  "db_name": "PostgreSQL",
-  "query": "SELECT coalesce(COUNT(*) FILTER(WHERE suspend = 0 AND running = false), 0) as \"database_length!\", coalesce(COUNT(*) FILTER(WHERE suspend > 0), 0) as \"suspended!\" FROM v2_as_queue WHERE (workspace_id = $1 OR $2) AND scheduled_for <= now()",
+  "query": "SELECT coalesce(COUNT(*) FILTER(WHERE suspend = 0 AND running = false), 0) as \"database_length!\", coalesce(COUNT(*) FILTER(WHERE suspend > 0), 0) as \"suspended!\" FROM v2_as_queue WHERE (workspace_id = $1 OR $2) AND scheduled_for <= now() AND ($3::text[] IS NULL OR tag = ANY($3))",
  "describe": {
    "columns": [
      {
@@ -17,7 +17,8 @@
    "parameters": {
      "Left": [
        "Text",
-        "Bool"
+        "Bool",
+        "TextArray"
      ]
    },
    "nullable": [
@@ -25,5 +26,5 @@
      null
    ]
  },
-  "hash": "19cc8499f682ec34d54bc4f694cb281a9bd7f5431c646c6268513751fff95395"
+  "hash": "0cb0e912bc942af2b1ef784455f3f073a79e300f3dd48f14122d1782eee663cd"
 }
--- a/backend/.sqlx/query-0efb16cbf130ec6e9922ecc82a95b252449bd569df374e40ce8820fc3d75a0f0.json
+++ b/backend/.sqlx/query-0efb16cbf130ec6e9922ecc82a95b252449bd569df374e40ce8820fc3d75a0f0.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "DROP INDEX CONCURRENTLY IF EXISTS queue_sort",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "0efb16cbf130ec6e9922ecc82a95b252449bd569df374e40ce8820fc3d75a0f0"
+}
--- a/backend/.sqlx/query-2fa27b0a71740e4e168879cf9a58ed593004c22bb5d11170b3196e290dd1d966.json
+++ b/backend/.sqlx/query-2fa27b0a71740e4e168879cf9a58ed593004c22bb5d11170b3196e290dd1d966.json
@@ -1,26 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "\n        WITH assigned_teams AS (\n        SELECT teams_team_id\n        FROM workspace_settings\n        ),\n        all_teams AS (\n        SELECT jsonb_array_elements(value::jsonb) AS team\n        FROM global_settings\n        WHERE name = 'teams'\n        )\n        SELECT team->>'team_name' AS team_name, team->>'team_internal_id' AS team_id\n        FROM all_teams\n        WHERE NOT EXISTS (\n        SELECT 1\n        FROM assigned_teams\n        WHERE assigned_teams.teams_team_id = team->>'team_internal_id'\n        )\n        AND team->>'team_name' IS NOT NULL\n        AND team->>'team_id' IS NOT NULL\n        ",
-  "describe": {
-    "columns": [
-      {
-        "ordinal": 0,
-        "name": "team_name",
-        "type_info": "Text"
-      },
-      {
-        "ordinal": 1,
-        "name": "team_id",
-        "type_info": "Text"
-      }
-    ],
-    "parameters": {
-      "Left": []
-    },
-    "nullable": [
-      null,
-      null
-    ]
-  },
-  "hash": "2fa27b0a71740e4e168879cf9a58ed593004c22bb5d11170b3196e290dd1d966"
-}
--- a/backend/.sqlx/query-3738096c29ab9d964be8a74bfd14ff1d599049ebefdaf97a017c9cef8d52ce20.json
+++ b/backend/.sqlx/query-3738096c29ab9d964be8a74bfd14ff1d599049ebefdaf97a017c9cef8d52ce20.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "DROP INDEX CONCURRENTLY IF EXISTS queue_sort_2",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "3738096c29ab9d964be8a74bfd14ff1d599049ebefdaf97a017c9cef8d52ce20"
+}
--- a/backend/.sqlx/query-3bacf9cd9aa63f4bec5f983f4a0c3030216b5a4ed669f77962509d1c2c6cb780.json
+++ b/backend/.sqlx/query-3bacf9cd9aa63f4bec5f983f4a0c3030216b5a4ed669f77962509d1c2c6cb780.json
@@ -1,12 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "create index concurrently if not exists root_job_index_by_path_2 ON v2_job (workspace_id, runnable_path, created_at desc) WHERE parent_job IS NULL",
-  "describe": {
-    "columns": [],
-    "parameters": {
-      "Left": []
-    },
-    "nullable": []
-  },
-  "hash": "3bacf9cd9aa63f4bec5f983f4a0c3030216b5a4ed669f77962509d1c2c6cb780"
-}
--- a/backend/.sqlx/query-3bbde0fa35d935ec2dd8bd1fb14cfecf48305f5f4b644b3c35355074e1ccce28.json
+++ b/backend/.sqlx/query-3bbde0fa35d935ec2dd8bd1fb14cfecf48305f5f4b644b3c35355074e1ccce28.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "CREATE INDEX CONCURRENTLY queue_sort_v2 ON v2_job_queue (priority DESC NULLS LAST, scheduled_for, tag) WHERE running = false",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "3bbde0fa35d935ec2dd8bd1fb14cfecf48305f5f4b644b3c35355074e1ccce28"
+}
--- a/backend/.sqlx/query-47455b0ebaf999ab58b2cba3d74cb4bdd64075939a4aa2c117e18372511ea7e0.json
+++ b/backend/.sqlx/query-47455b0ebaf999ab58b2cba3d74cb4bdd64075939a4aa2c117e18372511ea7e0.json
@@ -1,12 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "VACUUM (skip_locked) v2_job_queue, v2_job_runtime, v2_job_status",
-  "describe": {
-    "columns": [],
-    "parameters": {
-      "Left": []
-    },
-    "nullable": []
-  },
-  "hash": "47455b0ebaf999ab58b2cba3d74cb4bdd64075939a4aa2c117e18372511ea7e0"
-}
--- a/backend/.sqlx/query-50c17c7848760aaf0f869acfc444caecda6335eda5b2e97e5a7370361653ff48.json
+++ b/backend/.sqlx/query-50c17c7848760aaf0f869acfc444caecda6335eda5b2e97e5a7370361653ff48.json
@@ -0,0 +1,26 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        WITH assigned_teams AS (\n        SELECT teams_team_id\n        FROM workspace_settings\n        ),\n        all_teams AS (\n            SELECT jsonb_array_elements(CASE\n                WHEN jsonb_typeof(value::jsonb) = 'array' THEN value::jsonb\n                ELSE '[]'::jsonb\n            END) AS team\n            FROM global_settings\n            WHERE name = 'teams'\n        )\n        SELECT team->>'team_name' AS team_name, team->>'team_internal_id' AS team_id\n        FROM all_teams\n        WHERE NOT EXISTS (\n        SELECT 1\n        FROM assigned_teams\n        WHERE assigned_teams.teams_team_id = team->>'team_internal_id'\n        )\n        AND team->>'team_name' IS NOT NULL\n        AND team->>'team_id' IS NOT NULL\n        ",
+  "describe": {
+    "columns": [
+      {
+        "ordinal": 0,
+        "name": "team_name",
+        "type_info": "Text"
+      },
+      {
+        "ordinal": 1,
+        "name": "team_id",
+        "type_info": "Text"
+      }
+    ],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": [
+      null,
+      null
+    ]
+  },
+  "hash": "50c17c7848760aaf0f869acfc444caecda6335eda5b2e97e5a7370361653ff48"
+}
--- a/backend/.sqlx/query-6536214f31e9d600e868b01385d8c6395e2440ea27553b7ccb18d7149b106728.json
+++ b/backend/.sqlx/query-6536214f31e9d600e868b01385d8c6395e2440ea27553b7ccb18d7149b106728.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "DROP INDEX CONCURRENTLY IF EXISTS root_job_index_by_path_2",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "6536214f31e9d600e868b01385d8c6395e2440ea27553b7ccb18d7149b106728"
+}
--- a/backend/.sqlx/query-65c339164e7669360d231d70105849e72bdc197c17c0fc51777c1dc9267e2daf.json
+++ b/backend/.sqlx/query-65c339164e7669360d231d70105849e72bdc197c17c0fc51777c1dc9267e2daf.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        UPDATE workspace_settings\n        SET teams_command_script = NULL,\n            teams_team_id = NULL,\n            teams_team_name = NULL\n        ",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "65c339164e7669360d231d70105849e72bdc197c17c0fc51777c1dc9267e2daf"
+}
--- a/backend/.sqlx/query-b9b38d63af3670d1f11d5cbb82a8008a9479bf4b3d7231371ebf26382ecde365.json
+++ b/backend/.sqlx/query-b9b38d63af3670d1f11d5cbb82a8008a9479bf4b3d7231371ebf26382ecde365.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "VACUUM v2_job_queue, v2_job_runtime, v2_job_status",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "b9b38d63af3670d1f11d5cbb82a8008a9479bf4b3d7231371ebf26382ecde365"
+}
--- a/backend/.sqlx/query-c481e5d63ebf1aa537cc4ce4e84f9a71af5996bc76f328b3ba1cf68a71880462.json
+++ b/backend/.sqlx/query-c481e5d63ebf1aa537cc4ce4e84f9a71af5996bc76f328b3ba1cf68a71880462.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "create index concurrently if not exists ix_job_root_job_index_by_path_2 ON v2_job (workspace_id, runnable_path, created_at desc) WHERE parent_job IS NULL",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "c481e5d63ebf1aa537cc4ce4e84f9a71af5996bc76f328b3ba1cf68a71880462"
+}
--- a/backend/.sqlx/query-c92cc71e6d10c41368f7aa75b0799c2e1e9ca0ed33077ade8d7560e7cc21fa06.json
+++ b/backend/.sqlx/query-c92cc71e6d10c41368f7aa75b0799c2e1e9ca0ed33077ade8d7560e7cc21fa06.json
@@ -1,6 +1,6 @@
 {
  "db_name": "PostgreSQL",
-  "query": "DELETE FROM v2_job_queue WHERE workspace_id = $1 AND id = $2 RETURNING 1",
+  "query": "DELETE FROM v2_job_queue WHERE id = $1 RETURNING 1",
  "describe": {
    "columns": [
      {
@@ -11,7 +11,6 @@
    ],
    "parameters": {
      "Left": [
-        "Text",
        "Uuid"
      ]
    },
@@ -19,5 +18,5 @@
      null
    ]
  },
-  "hash": "d25c58d2722ad3dcd91101ce6f66e1d802dd5d82e1cd5f5ed3a15cbc75eb6745"
+  "hash": "c92cc71e6d10c41368f7aa75b0799c2e1e9ca0ed33077ade8d7560e7cc21fa06"
 }
--- a/backend/.sqlx/query-df3b60c1d0fb44c97bf2611a7cda6bdb16a1be66e993a5cfadf6de2e3c8a5021.json
+++ b/backend/.sqlx/query-df3b60c1d0fb44c97bf2611a7cda6bdb16a1be66e993a5cfadf6de2e3c8a5021.json
@@ -0,0 +1,12 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        UPDATE global_settings\n        SET value = (\n            SELECT jsonb_agg(elem)\n            FROM jsonb_array_elements(value) AS elem\n            WHERE NOT (elem ? 'teams_channel')\n        )\n        WHERE name = 'critical_error_channels'\n        ",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": []
+    },
+    "nullable": []
+  },
+  "hash": "df3b60c1d0fb44c97bf2611a7cda6bdb16a1be66e993a5cfadf6de2e3c8a5021"
+}
--- a/backend/.sqlx/query-e565f3b2e51059f563d18a8a9442bcae9640cee7b936820cb46c011222a77ff0.json
+++ b/backend/.sqlx/query-e565f3b2e51059f563d18a8a9442bcae9640cee7b936820cb46c011222a77ff0.json
@@ -0,0 +1,14 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "UPDATE global_settings SET value = $1 WHERE name = 'teams'",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": [
+        "Jsonb"
+      ]
+    },
+    "nullable": []
+  },
+  "hash": "e565f3b2e51059f563d18a8a9442bcae9640cee7b936820cb46c011222a77ff0"
+}
--- a/backend/Cargo.lock
+++ b/backend/Cargo.lock
@@ -1668,9 +1668,9 @@ dependencies = [

 [[package]]
 name = "clap"
-version = "4.5.29"
+version = "4.5.30"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8acebd8ad879283633b343856142139f2da2317c96b05b4dd6181c61e2480184"
+checksum = "92b7b18d71fad5313a1e320fa9897994228ce274b60faa4d694fe0ea89cd9e6d"
 dependencies = [
 "clap_builder",
 "clap_derive",
@@ -1678,9 +1678,9 @@ dependencies = [

 [[package]]
 name = "clap_builder"
-version = "4.5.29"
+version = "4.5.30"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f6ba32cbda51c7e1dfd49acc1457ba1a7dec5b64fe360e828acb13ca8dc9c2f9"
+checksum = "a35db2071778a7344791a4fb4f95308b5673d219dee3ae348b86642574ecc90c"
 dependencies = [
 "anstream",
 "anstyle",
@@ -6795,7 +6795,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "3779b94aeb87e8bd4e834cee3650289ee9e0d5677f976ecdb6d219e5f4f6cd94"
 dependencies = [
 "rand_chacha 0.9.0",
- "rand_core 0.9.0",
+ "rand_core 0.9.1",
 "zerocopy 0.8.18",
 ]

@@ -6826,7 +6826,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "d3022b5f1df60f26e1ffddd6c66e8aa15de382ae63b3a0c1bfc0e4d3e3f325cb"
 dependencies = [
 "ppv-lite86",
- "rand_core 0.9.0",
+ "rand_core 0.9.1",
 ]

 [[package]]
@@ -6849,9 +6849,9 @@ dependencies = [

 [[package]]
 name = "rand_core"
-version = "0.9.0"
+version = "0.9.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b08f3c9802962f7e1b25113931d94f43ed9725bebc59db9d0c3e9a23b67e15ff"
+checksum = "a88e0da7a2c97baa202165137c158d0a2e824ac465d13d81046727b34cb247d3"
 dependencies = [
 "getrandom 0.3.1",
 "zerocopy 0.8.18",
@@ -7575,9 +7575,9 @@ checksum = "6ea1a2d0a644769cc99faa24c3ad26b379b786fe7c36fd3c546254801650e6dd"

 [[package]]
 name = "ryu-js"
-version = "1.0.1"
+version = "1.0.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ad97d4ce1560a5e27cec89519dc8300d1aa6035b099821261c651486a19e44d5"
+checksum = "dd29631678d6fb0903b69223673e122c32e9ae559d0960a38d574695ebc0ea15"

 [[package]]
 name = "safetensors"
@@ -9297,9 +9297,9 @@ dependencies = [

 [[package]]
 name = "tempfile"
-version = "3.16.0"
+version = "3.17.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "38c246215d7d24f48ae091a2902398798e05d978b24315d6efbc00ede9a8bb91"
+checksum = "22e5a0acb1f3f55f65cc4a866c361b2fb2a0ff6366785ae6fbb5f85df07ba230"
 dependencies = [
 "cfg-if",
 "fastrand 2.3.0",
@@ -10858,7 +10858,7 @@ checksum = "712e227841d057c1ee1cd2fb22fa7e5a5461ae8e48fa2ca79ec42cfc1931183f"

 [[package]]
 name = "windmill"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "axum",
@@ -10901,7 +10901,7 @@ dependencies = [

 [[package]]
 name = "windmill-api"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "argon2",
@@ -10995,7 +10995,7 @@ dependencies = [

 [[package]]
 name = "windmill-api-client"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "base64 0.22.1",
 "chrono",
@@ -11013,7 +11013,7 @@ dependencies = [

 [[package]]
 name = "windmill-audit"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "chrono",
 "serde",
@@ -11026,7 +11026,7 @@ dependencies = [

 [[package]]
 name = "windmill-autoscaling"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "serde",
@@ -11040,7 +11040,7 @@ dependencies = [

 [[package]]
 name = "windmill-common"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "async-stream",
@@ -11099,7 +11099,7 @@ dependencies = [

 [[package]]
 name = "windmill-git-sync"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "regex",
 "serde",
@@ -11113,7 +11113,7 @@ dependencies = [

 [[package]]
 name = "windmill-indexer"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "bytes",
@@ -11136,7 +11136,7 @@ dependencies = [

 [[package]]
 name = "windmill-macros"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "itertools 0.14.0",
 "lazy_static",
@@ -11148,7 +11148,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "convert_case 0.6.0",
 "serde",
@@ -11157,7 +11157,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-bash"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "lazy_static",
@@ -11169,7 +11169,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-csharp"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "serde_json",
@@ -11181,7 +11181,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-go"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "gosyn",
@@ -11193,7 +11193,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-graphql"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "lazy_static",
@@ -11205,7 +11205,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-php"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "itertools 0.14.0",
@@ -11216,7 +11216,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-py"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "itertools 0.14.0",
@@ -11227,7 +11227,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-py-imports"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "async-recursion",
@@ -11247,7 +11247,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-rust"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "convert_case 0.6.0",
@@ -11264,7 +11264,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-sql"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "lazy_static",
@@ -11276,7 +11276,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-ts"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "lazy_static",
@@ -11294,7 +11294,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-wasm"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "getrandom 0.2.15",
@@ -11316,7 +11316,7 @@ dependencies = [

 [[package]]
 name = "windmill-parser-yaml"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "serde_json",
@@ -11326,7 +11326,7 @@ dependencies = [

 [[package]]
 name = "windmill-queue"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "async-recursion",
@@ -11359,7 +11359,7 @@ dependencies = [

 [[package]]
 name = "windmill-sql-datatype-parser-wasm"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "wasm-bindgen",
 "wasm-bindgen-test",
@@ -11369,7 +11369,7 @@ dependencies = [

 [[package]]
 name = "windmill-worker"
-version = "1.463.2"
+version = "1.463.4"
 dependencies = [
 "anyhow",
 "async-recursion",
--- a/backend/Cargo.toml
+++ b/backend/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "windmill"
-version = "1.463.2"
+version = "1.463.4"
 authors.workspace = true
 edition.workspace = true

@@ -30,7 +30,7 @@ members = [
 ]

 [workspace.package]
-version = "1.463.2"
+version = "1.463.4"
 authors = ["Ruben Fiszel <ruben@windmill.dev>"]
 edition = "2021"

--- a/backend/ee-repo-ref.txt
+++ b/backend/ee-repo-ref.txt
@@ -1 +1 @@
-703a03ac430b6f603a5a189e5b4ff9a42bb2bd7f
+e507af5589efb1a8a72ae4e231130f749bde738d
--- a/backend/migrations/20250205131519_windmill_admin_skip_bypassrls_on_v2_job.down.sql
+++ b/backend/migrations/20250205131519_windmill_admin_skip_bypassrls_on_v2_job.down.sql
@@ -0,0 +1 @@
+-- Add down migration script here
--- a/backend/migrations/20250205131519_windmill_admin_skip_bypassrls_on_v2_job.up.sql
+++ b/backend/migrations/20250205131519_windmill_admin_skip_bypassrls_on_v2_job.up.sql
@@ -0,0 +1,3 @@
+-- Add up migration script here
+DROP POLICY IF EXISTS admin_policy ON v2_job;
+CREATE POLICY admin_policy ON v2_job FOR ALL TO windmill_admin USING (true);
--- a/backend/pg_log_tail
+++ b/backend/pg_log_tail
--- a/backend/windmill-api/openapi.yaml
+++ b/backend/windmill-api/openapi.yaml
@@ -1,7 +1,7 @@
 openapi: "3.0.3"

 info:
-  version: 1.463.2
+  version: 1.463.4
  title: Windmill API

  contact:
--- a/backend/windmill-api/src/db.rs
+++ b/backend/windmill-api/src/db.rs
@@ -545,8 +545,8 @@ async fn fix_job_completed_index(db: &DB) -> Result<(), Error> {
            .await?;
    });

-    run_windmill_migration!("fix_job_index_1", &db, |tx| {
-        let migration_job_name = "fix_job_completed_index_4";
+    run_windmill_migration!("fix_job_index_1_II", &db, |tx| {
+        let migration_job_name = "fix_job_index_1_II";
        let mut i = 1;
        tracing::info!("step {i} of {migration_job_name} migration");
        sqlx::query!("create index concurrently  if not exists ix_job_workspace_id_created_at_new_3 ON v2_job  (workspace_id,  created_at DESC)")
@@ -579,13 +579,20 @@ async fn fix_job_completed_index(db: &DB) -> Result<(), Error> {
        i += 1;
        tracing::info!("step {i} of {migration_job_name} migration");

-        sqlx::query!("create index concurrently if not exists root_job_index_by_path_2 ON v2_job (workspace_id, runnable_path, created_at desc) WHERE parent_job IS NULL")
+        sqlx::query!("create index concurrently if not exists ix_job_root_job_index_by_path_2 ON v2_job (workspace_id, runnable_path, created_at desc) WHERE parent_job IS NULL")
                .execute(db)
                .await?;

        i += 1;
        tracing::info!("step {i} of {migration_job_name} migration");

+        sqlx::query!("DROP INDEX CONCURRENTLY IF EXISTS root_job_index_by_path_2")
+            .execute(db)
+            .await?;
+
+        i += 1;
+        tracing::info!("step {i} of {migration_job_name} migration");
+
        sqlx::query!("create index concurrently if not exists ix_job_created_at ON v2_job  (created_at DESC)")
                    .execute(db)
                    .await?;
@@ -655,6 +662,23 @@ async fn fix_job_completed_index(db: &DB) -> Result<(), Error> {
            .await?;
    });

+    run_windmill_migration!("v2_improve_v2_queued_jobs_indices", &db, |tx| {
+        sqlx::query!("CREATE INDEX CONCURRENTLY queue_sort_v2 ON v2_job_queue (priority DESC NULLS LAST, scheduled_for, tag) WHERE running = false")
+            .execute(db)
+            .await?;
+
+        // sqlx::query!("CREATE INDEX CONCURRENTLY queue_sort_2_v2 ON v2_job_queue (tag, priority DESC NULLS LAST, scheduled_for) WHERE running = false")
+        //     .execute(db)
+        //     .await?;
+
+        sqlx::query!("DROP INDEX CONCURRENTLY IF EXISTS queue_sort")
+            .execute(db)
+            .await?;
+
+        sqlx::query!("DROP INDEX CONCURRENTLY IF EXISTS queue_sort_2")
+            .execute(db)
+            .await?;
+    });
    Ok(())
 }

--- a/backend/windmill-api/src/jobs.rs
+++ b/backend/windmill-api/src/jobs.rs
@@ -1161,7 +1161,7 @@ pub struct ListableCompletedJob {
    pub parent_job: Option<Uuid>,
    pub created_by: String,
    pub created_at: chrono::DateTime<chrono::Utc>,
-    pub started_at: chrono::DateTime<chrono::Utc>,
+    pub started_at: Option<chrono::DateTime<chrono::Utc>>,
    pub duration_ms: i64,
    pub success: bool,
    #[serde(skip_serializing_if = "Option::is_none")]
@@ -1647,6 +1647,7 @@ struct QueueStats {
 #[derive(Deserialize)]
 pub struct CountQueueJobsQuery {
    all_workspaces: Option<bool>,
+    tags: Option<String>,
 }

 async fn count_queue_jobs(
@@ -1654,12 +1655,16 @@ async fn count_queue_jobs(
    Path(w_id): Path<String>,
    Query(cq): Query<CountQueueJobsQuery>,
 ) -> error::JsonResult<QueueStats> {
+    let tags = cq
+        .tags
+        .map(|t| t.split(',').map(|s| s.to_string()).collect::<Vec<_>>());
    Ok(Json(
        sqlx::query_as!(
            QueueStats,
-            "SELECT coalesce(COUNT(*) FILTER(WHERE suspend = 0 AND running = false), 0) as \"database_length!\", coalesce(COUNT(*) FILTER(WHERE suspend > 0), 0) as \"suspended!\" FROM v2_as_queue WHERE (workspace_id = $1 OR $2) AND scheduled_for <= now()",
+            "SELECT coalesce(COUNT(*) FILTER(WHERE suspend = 0 AND running = false), 0) as \"database_length!\", coalesce(COUNT(*) FILTER(WHERE suspend > 0), 0) as \"suspended!\" FROM v2_as_queue WHERE (workspace_id = $1 OR $2) AND scheduled_for <= now() AND ($3::text[] IS NULL OR tag = ANY($3))",
            w_id,
            w_id == "admins" && cq.all_workspaces.unwrap_or(false),
+            tags.as_ref().map(|v| v.as_slice())
        )
        .fetch_one(&db)
        .await?,
@@ -1800,13 +1805,13 @@ async fn list_jobs(
        }
        sqlc.unwrap().limit(per_page).offset(offset).query()?
    };
-    let mut tx = user_db.begin(&authed).await?;
+    let mut tx: Transaction<'_, Postgres> = user_db.begin(&authed).await?;

    #[cfg(feature = "prometheus")]
    let start = Instant::now();

    #[cfg(feature = "prometheus")]
-    if _api_list_jobs_query_duration.is_some() {
+    if _api_list_jobs_query_duration.is_some() || true {
        tracing::info!("list_jobs query: {}", sql);
    }

@@ -4695,6 +4700,7 @@ struct BatchInfo {
    flow_value: Option<FlowValue>,
    path: Option<String>,
    rawscript: Option<BatchRawScript>,
+    tag: Option<String>,
 }

 #[tracing::instrument(level = "trace", skip_all)]
@@ -4863,6 +4869,8 @@ async fn add_batch_jobs(
        } else {
            format!("{}", language.as_str())
        }
+    } else if let Some(tag) = batch_info.tag {
+        tag
    } else {
        format!("{}", language.as_str())
    };
--- a/backend/windmill-common/src/utils.rs
+++ b/backend/windmill-common/src/utils.rs
@@ -47,8 +47,11 @@ lazy_static::lazy_static! {
        .connect_timeout(std::time::Duration::from_secs(10))
        .build().unwrap();
    pub static ref GIT_SEM_VERSION: Version = Version::parse(
-        // skip first `v` character.
-        GIT_VERSION.split_at(1).1
+        if GIT_VERSION.starts_with('v') {
+            &GIT_VERSION[1..]
+        } else {
+            GIT_VERSION
+        }
    ).unwrap_or(Version::new(0, 1, 0));
 }

--- a/backend/windmill-common/src/worker.rs
+++ b/backend/windmill-common/src/worker.rs
@@ -657,7 +657,7 @@ pub async fn update_min_version<'c, E: sqlx::Executor<'c, Database = sqlx::Postg
    let min_version = pings
        .iter()
        .filter(|x| !x.is_empty())
-        .filter_map(|x| semver::Version::parse(x.split_at(1).1).ok())
+        .filter_map(|x| semver::Version::parse(if x.starts_with('v') { &x[1..] } else { x }).ok())
        .min()
        .unwrap_or_else(|| cur_version.clone());

--- a/backend/windmill-queue/src/jobs.rs
+++ b/backend/windmill-queue/src/jobs.rs
@@ -566,6 +566,9 @@ pub async fn add_completed_job<T: Serialize + Send + Sync + ValidableJson>(
    let result_columns = result_columns.as_ref();
    let _job_id = queued_job.id;
    let (opt_uuid, _duration, _skip_downstream_error_handlers) = (|| async {
+
+        // let start = std::time::Instant::now();
+
        let mut tx = db.begin().await?;

        let job_id = queued_job.id;
@@ -663,7 +666,7 @@ pub async fn add_completed_job<T: Serialize + Send + Sync + ValidableJson>(
        // tracing::error!("Added completed job {:#?}", queued_job);

        let mut _skip_downstream_error_handlers = false;
-        tx = delete_job(tx, &queued_job.workspace_id, job_id).await?;
+        tx = delete_job(tx, &job_id).await?;
        // tracing::error!("3 {:?}", start.elapsed());

        if queued_job.is_flow_step {
@@ -858,6 +861,7 @@ pub async fn add_completed_job<T: Serialize + Send + Sync + ValidableJson>(
            "inserted completed job: {} (success: {success})",
            queued_job.id
        );
+        // tracing::info!("completed job: {:?}", start.elapsed().as_micros());
        Ok((None, _duration, _skip_downstream_error_handlers)) as windmill_common::error::Result<(Option<Uuid>, i64, bool)>
    })
    .retry(
@@ -2108,12 +2112,15 @@ async fn pull_single_job_and_mark_as_running_no_concurrency_limit<'c>(

            for query in queries.iter() {
                // tracing::info!("Pulling job with query: {}", query);
+                // let instant = std::time::Instant::now();
                let r = sqlx::query_as::<_, PulledJob>(query)
                    .bind(worker_name)
                    .fetch_optional(db)
                    .await?;

                if let Some(pulled_job) = r {
+                    // tracing::info!("pulled job: {:?}", instant.elapsed().as_micros());
+
                    highest_priority_job = Some(pulled_job);
                    break;
                }
@@ -2594,21 +2601,17 @@ async fn extract_result_from_job_result(

 pub async fn delete_job<'c>(
    mut tx: Transaction<'c, Postgres>,
-    w_id: &str,
-    job_id: Uuid,
+    job_id: &Uuid,
 ) -> windmill_common::error::Result<Transaction<'c, Postgres>> {
    #[cfg(feature = "prometheus")]
    if METRICS_ENABLED.load(std::sync::atomic::Ordering::Relaxed) {
        QUEUE_DELETE_COUNT.inc();
    }

-    let job_removed = sqlx::query_scalar!(
-        "DELETE FROM v2_job_queue WHERE workspace_id = $1 AND id = $2 RETURNING 1",
-        w_id,
-        job_id
-    )
-    .fetch_optional(&mut *tx)
-    .await;
+    let job_removed =
+        sqlx::query_scalar!("DELETE FROM v2_job_queue WHERE id = $1 RETURNING 1", job_id,)
+            .fetch_optional(&mut *tx)
+            .await;

    if let Err(job_removed) = job_removed {
        tracing::error!(
--- a/backend/windmill-worker/src/worker.rs
+++ b/backend/windmill-worker/src/worker.rs
@@ -1277,7 +1277,7 @@ pub async fn run_worker(
            tokio::task::spawn(
                (async move {
                    tracing::info!(worker = %worker_name, hostname = %hostname, "vacuuming queue");
-                    if let Err(e) = sqlx::query!("VACUUM (skip_locked) v2_job_queue, v2_job_runtime, v2_job_status")
+                    if let Err(e) = sqlx::query!("VACUUM v2_job_queue, v2_job_runtime, v2_job_status")
                        .execute(&db2)
                        .await
                    {
--- a/benchmarks/benchmark_oneoff.ts
+++ b/benchmarks/benchmark_oneoff.ts
@@ -26,7 +26,7 @@ async function verifyOutputs(uuids: string[], workspace: string) {
        incorrectResults++;
      }
      if (job.result !== uuid) {
-        console.log(`Job ${uuid} did not output the correct value`);
+        console.log(`Job ${uuid} did not output the correct value: ${JSON.stringify(job)}`);
        incorrectResults++;
      }
    } catch (_) {
@@ -37,6 +37,7 @@ async function verifyOutputs(uuids: string[], workspace: string) {
  console.log(`Incorrect results: ${incorrectResults}`);
 }

+export const NON_TEST_TAGS = ["deno", "python", "go", "bash", "dedicated", "bun", "nativets", "flow"]
 export async function main({
  host,
  email,
@@ -96,11 +97,11 @@ export async function main({
  windmill.setClient(final_token, host);
  const enc = (s: string) => new TextEncoder().encode(s);

-  async function getQueueCount() {
+  async function getQueueCount(tags?: string[]) {
    return (
      await (
        await fetch(
-          config.server + "/api/w/" + config.workspace_id + "/jobs/queue/count",
+          config.server + "/api/w/" + config.workspace_id + "/jobs/queue/count" + (tags && tags.length > 0 ? "?tags=" + tags.join(",") : ""),
          { headers: { ["Authorization"]: "Bearer " + config.token } }
        )
      ).json()
@@ -132,11 +133,11 @@ export async function main({
  }

  let pastJobs = 0;
-  async function getCompletedJobsCount(): Promise<number> {
+  async function getCompletedJobsCount(tags?: string[]): Promise<number> {
    const completedJobs = (
      await (
        await fetch(
-          host + "/api/w/" + config.workspace_id + "/jobs/completed/count",
+          host + "/api/w/" + config.workspace_id + "/jobs/completed/count" + (tags && tags.length > 0 ? "?tags=" + tags.join(",") : ""),
          { headers: { ["Authorization"]: "Bearer " + config.token } }
        )
      ).json()
@@ -152,7 +153,6 @@ export async function main({
    await createBenchScript(kind, workspace);
  }

-  pastJobs = await getCompletedJobsCount();

  const jobsSent = jobs;
  console.log(`Bulk creating ${jobsSent} jobs`);
@@ -201,18 +201,51 @@ export async function main({
      kind: "rawscript",
      rawscript: {
        language: api.RawScript.language.BASH,
-        content: "# let's bloat that bash script, 3.. 2.. 1.. BOOM\n".repeat(25000) + "echo \"$WM_FLOW_JOB_ID\"\n",
+        content: "# let's bloat that bash script, 3.. 2.. 1.. BOOM\n".repeat(100) + "echo \"$WM_FLOW_JOB_ID\"\n",
      },
    });
  } else {
    throw new Error("Unknown script pattern " + kind);
  }

-  const response = await fetch(
-    config.server +
+  let testOtherTag = false;
+  if (testOtherTag) {
+    const otherTagTodo = 2000000;
+
+    let parsed = JSON.parse(body);
+    parsed.tag = "test";
+    let nbody = JSON.stringify(parsed);
+    let response2 = await fetch(
+      config.server +
      "/api/w/" +
      config.workspace_id +
-      `/jobs/add_batch_jobs/${jobsSent}`,
+      `/jobs/add_batch_jobs/${otherTagTodo}`,
+      {
+        method: "POST",
+        headers: {
+          ["Authorization"]: "Bearer " + config.token,
+          "Content-Type": "application/json",
+        },
+        body: nbody,
+      }
+    );
+    if (!response2.ok) {
+      throw new Error(
+        "Failed to create jobs: " +
+        response2.statusText +
+        " " +
+        (await response2.text())
+      );
+    }
+  }
+
+  pastJobs = await getCompletedJobsCount(NON_TEST_TAGS);
+
+  const response = await fetch(
+    config.server +
+    "/api/w/" +
+    config.workspace_id +
+    `/jobs/add_batch_jobs/${jobsSent}`,
    {
      method: "POST",
      headers: {
@@ -222,20 +255,24 @@ export async function main({
      body,
    }
  );
+
+
+
+
+
  if (!response.ok) {
    throw new Error(
      "Failed to create jobs: " +
-        response.statusText +
-        " " +
-        (await response.text())
+      response.statusText +
+      " " +
+      (await response.text())
    );
  }
  const uuids = await response.json();
  const end_create = Date.now();
  const create_duration = end_create - start_create;
  console.log(
-    `Jobs successfully added to the queue in ${
-      create_duration / 1000
+    `Jobs successfully added to the queue in ${create_duration / 1000
    }s. Windmill will start pulling them\n`
  );
  let start = Date.now();
@@ -248,14 +285,14 @@ export async function main({
  while (completedJobs < jobsSent) {
    const loopStart = Date.now();
    if (!didStart) {
-      const actual_queue = await getQueueCount();
+      const actual_queue = await getQueueCount(NON_TEST_TAGS);
      if (actual_queue < jobsSent) {
        start = Date.now();
        didStart = true;
      }
    } else {
      const elapsed = start ? Date.now() - start : 0;
-      completedJobs = await getCompletedJobsCount();
+      completedJobs = await getCompletedJobsCount(NON_TEST_TAGS);
      if (nStepsFlow > 0) {
        completedJobs = Math.floor(completedJobs / (nStepsFlow + 1));
      }
@@ -263,9 +300,9 @@ export async function main({
      const instThr =
        lastElapsed > 0
          ? (
-              ((completedJobs - lastCompletedJobs) / (elapsed - lastElapsed)) *
-              1000
-            ).toFixed(2)
+            ((completedJobs - lastCompletedJobs) / (elapsed - lastElapsed)) *
+            1000
+          ).toFixed(2)
          : 0;

      lastElapsed = elapsed;
@@ -275,8 +312,7 @@ export async function main({
        enc(
          `elapsed: ${(elapsed / 1000).toFixed(
            2
-          )} | jobs executed: ${completedJobs}/${jobsSent} (thr: inst ${instThr} - avg ${avgThr}) | remaining: ${
-            jobsSent - completedJobs
+          )} | jobs executed: ${completedJobs}/${jobsSent} (thr: inst ${instThr} - avg ${avgThr}) | remaining: ${jobsSent - completedJobs
          }                          \r`
        )
      );
@@ -294,7 +330,7 @@ export async function main({
  console.log(`avg. throughput (jobs/time): ${jobsSent / total_duration_sec}`);

  console.log("completed jobs", completedJobs);
-  console.log("queue length:", await getQueueCount());
+  console.log("queue length:", await getQueueCount(NON_TEST_TAGS));

  if (
    !noVerify &&
--- a/benchmarks/benchmark_suite.ts
+++ b/benchmarks/benchmark_suite.ts
@@ -39,6 +39,7 @@ async function main({
  workspace,
  configPath,
  workers,
+  factor
 }: {
  host: string;
  email?: string;
@@ -47,6 +48,7 @@ async function main({
  workspace: string;
  configPath: string;
  workers: number;
+  factor?: number;
 }) {
  async function getConfig(configPath: string): Promise<Config> {
    if (configPath.startsWith("http")) {
@@ -77,7 +79,7 @@ async function main({
          token,
          workspace,
          kind: benchmark.kind,
-          jobs: benchmark.jobs,
+          jobs: benchmark.jobs * (factor ?? 1),
        });

        if (benchmark.noSave) {
@@ -153,6 +155,9 @@ await new Command()
    "Number of workers that are used to run the benchmarks (only affect graph title)",
    { default: 1 }
  )
+  .option("--factor <factor:number>", "Factor to multiply the number of jobs by.", {
+    default: 1,
+  })
  .action(main)
  .command(
    "upgrade",
--- a/benchmarks/lib.ts
+++ b/benchmarks/lib.ts
@@ -2,7 +2,7 @@ import { sleep } from "https://deno.land/x/sleep@v1.2.1/mod.ts";
 import * as windmill from "https://deno.land/x/windmill@v1.174.0/mod.ts";
 import * as api from "https://deno.land/x/windmill@v1.174.0/windmill-api/index.ts";

-export const VERSION = "v1.463.2";
+export const VERSION = "v1.463.4";

 export async function login(email: string, password: string): Promise<string> {
  return await windmill.UserService.login({
@@ -25,7 +25,7 @@ async function waitForDeployment(workspace: string, hash: string) {
      if (resp.lock !== null) {
        return;
      }
-    } catch (err) {}
+    } catch (err) { }
    await sleep(0.5);
  }
  throw new Error("Script did not deploy in time");
@@ -246,7 +246,7 @@ export const getFlowPayload = (flowPattern: string): api.FlowPreview => {
              input_transforms: {},
              language: api.RawScript.language.BASH,
              type: "rawscript",
-              content: "# let's bloat that bash script, 3.. 2.. 1.. BOOM\n".repeat(25000) + "echo \"$WM_FLOW_JOB_ID\"\n",
+              content: "# let's bloat that bash script, 3.. 2.. 1.. BOOM\n".repeat(100) + `if [[ -z $\{WM_FLOW_JOB_ID+x\} ]]; then\necho "not set"\nelif [[ -z "$WM_FLOW_JOB_ID" ]]; then\necho "empty"\nelse\necho "$WM_FLOW_JOB_ID"\nfi`,
            },
          }
        ],
--- a/cli/main.ts
+++ b/cli/main.ts
@@ -62,7 +62,7 @@ export {
 //   }
 // });

-export const VERSION = "1.463.2";
+export const VERSION = "1.463.4";

 const command = new Command()
  .name("wmill")
--- a/frontend/package-lock.json
+++ b/frontend/package-lock.json
@@ -1,12 +1,12 @@
 {
 	"name": "windmill-components",
-	"version": "1.463.2",
+	"version": "1.463.4",
 	"lockfileVersion": 3,
 	"requires": true,
 	"packages": {
 		"": {
 			"name": "windmill-components",
-			"version": "1.463.2",
+			"version": "1.463.4",
 			"license": "AGPL-3.0",
 			"dependencies": {
 				"@anthropic-ai/sdk": "^0.32.1",
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "windmill-components",
-	"version": "1.463.2",
+	"version": "1.463.4",
 	"scripts": {
 		"dev": "vite dev",
 		"build": "vite build",
--- a/frontend/src/routes/(root)/(logged)/workspace_settings/+page.svelte
+++ b/frontend/src/routes/(root)/(logged)/workspace_settings/+page.svelte
@@ -447,11 +447,14 @@
 		if (emptyString($enterpriseLicense)) {
 			errorHandlerSelected = 'custom'
 		} else {
-			errorHandlerSelected = 
-				emptyString(errorHandlerScriptPath) ? 'custom' :
-				(errorHandlerScriptPath.startsWith('hub/') && errorHandlerScriptPath.endsWith('/workspace-or-schedule-error-handler-slack')) ? 'slack' :
-				(errorHandlerScriptPath.endsWith('/workspace-or-schedule-error-handler-teams')) ? 'teams' :
-				'custom'
+			errorHandlerSelected = emptyString(errorHandlerScriptPath)
+				? 'custom'
+				: errorHandlerScriptPath.startsWith('hub/') &&
+				  errorHandlerScriptPath.endsWith('/workspace-or-schedule-error-handler-slack')
+				? 'slack'
+				: errorHandlerScriptPath.endsWith('/workspace-or-schedule-error-handler-teams')
+				? 'teams'
+				: 'custom'
 		}
 		errorHandlerExtraArgs = settings.error_handler_extra_args ?? {}
 		workspaceDefaultAppPath = settings.default_app
@@ -812,8 +815,8 @@
 					{#if !$enterpriseLicense}
 						<div class="pt-4" />
 						<Alert type="info" title="Workspace Teams commands is an EE feature">
-							Workspace Teams commands is a Windmill EE feature. It enables using your current Slack / Teams
-							connection to run a custom script and send notifications.
+							Workspace Teams commands is a Windmill EE feature. It enables using your current Slack
+							/ Teams connection to run a custom script and send notifications.
 						</Alert>
 						<div class="pb-2" />
 					{/if}
@@ -867,12 +870,7 @@

 			<div class="mt-20" />
 			<PageHeader title="Delete workspace" primary={false} />
-			{#if $superadmin}
-				<p class="italic text-xs">
-					When deleting the workspace, it will be archived for a short period of time and then
-					permanently deleted.
-				</p>
-			{:else}
+			{#if !$superadmin}
 				<p class="italic text-xs"> Only instance superadmins can delete a workspace. </p>
 			{/if}
 			{#if $workspaceStore === 'admins' || $workspaceStore === 'starter'}
--- a/lsp/Pipfile
+++ b/lsp/Pipfile
@@ -4,8 +4,8 @@ verify_ssl = true
 name = "pypi"

 [packages]
-wmill = ">=1.463.2"
-wmill_pg = ">=1.463.2"
+wmill = ">=1.463.4"
+wmill_pg = ">=1.463.4"
 sendgrid = "*"
 mysql-connector-python = "*"
 pymongo = "*"
--- a/openflow.openapi.yaml
+++ b/openflow.openapi.yaml
@@ -1,7 +1,7 @@
 openapi: "3.0.3"

 info:
-  version: 1.463.2
+  version: 1.463.4
  title: OpenFlow Spec
  contact:
    name: Ruben Fiszel
--- a/powershell-client/WindmillClient/WindmillClient.psd1
+++ b/powershell-client/WindmillClient/WindmillClient.psd1
@@ -12,7 +12,7 @@
    RootModule        = 'WindmillClient.psm1'

    # Version number of this module.
-    ModuleVersion     = '1.463.2'
+    ModuleVersion     = '1.463.4'

    # Supported PSEditions
    # CompatiblePSEditions = @()
--- a/python-client/wmill/pyproject.toml
+++ b/python-client/wmill/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "wmill"
-version = "1.463.2"
+version = "1.463.4"
 description = "A client library for accessing Windmill server wrapping the Windmill client API"
 license = "Apache-2.0"
 homepage = "https://windmill.dev"
--- a/python-client/wmill_pg/pyproject.toml
+++ b/python-client/wmill_pg/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "wmill-pg"
-version = "1.463.2"
+version = "1.463.4"
 description = "An extension client for the wmill client library focused on pg"
 license = "Apache-2.0"
 homepage = "https://windmill.dev"
--- a/typescript-client/jsr.json
+++ b/typescript-client/jsr.json
@@ -1,6 +1,6 @@
 {
  "name": "@windmill/windmill",
-  "version": "1.463.2",
+  "version": "1.463.4",
  "exports": "./src/index.ts",
  "publish": {
    "exclude": ["!src", "./s3Types.ts", "./client.ts"]
--- a/typescript-client/package.json
+++ b/typescript-client/package.json
@@ -1,7 +1,7 @@
 {
  "name": "windmill-client",
  "description": "Windmill SDK client for browsers and Node.js",
-  "version": "1.463.2",
+  "version": "1.463.4",
  "author": "Ruben Fiszel",
  "license": "Apache 2.0",
  "devDependencies": {
--- a/version.txt
+++ b/version.txt
@@ -1 +1 @@
-1.463.2
+1.463.4
Author	SHA1	Message	Date
Ruben Fiszel	0c391e92a2	improve benchmarks	2025-02-18 09:51:21 +01:00
Ruben Fiszel	588ff79364	make benchmarks even more stable	2025-02-18 08:43:03 +01:00
Ruben Fiszel	3b6585afdf	nit benchmarks	2025-02-18 01:54:14 +01:00
Ruben Fiszel	3d7882577f	chore(main): release 1.463.4 (#5309 ) * chore(main): release 1.463.4 * Update CHANGELOG.md * Apply automatic changes --------- Co-authored-by: rubenfiszel <275584+rubenfiszel@users.noreply.github.com>	2025-02-18 00:55:01 +01:00
Ruben Fiszel	9234701f05	ensure index creation of root_job_by_path	2025-02-17 23:57:38 +01:00
Alexander Petric	935b5b7996	fix: improve teams settings in workspace settings (#5316 )	2025-02-17 22:44:26 +01:00
Ruben Fiszel	c6b2e6653a	output incorrect jobs in benchmarks	2025-02-17 22:20:33 +01:00
Ruben Fiszel	0dd0a795a6	nit benchmarks improvement	2025-02-17 21:54:58 +01:00
Ruben Fiszel	953082681e	fix: improve que job indices for faster performances	2025-02-17 21:26:46 +01:00
Ruben Fiszel	e0d7a54a2d	nit on bench scripts	2025-02-17 19:26:34 +01:00
Ruben Fiszel	85c56e9450	fix: improve que job indices for faster performances	2025-02-17 19:17:30 +01:00
Ruben Fiszel	5e22690bd9	fix: improve que job indices for faster performances	2025-02-17 17:56:28 +01:00
Ruben Fiszel	fe337293da	chore(main): release 1.463.3 (#5308 ) * chore(main): release 1.463.3 * Apply automatic changes --------- Co-authored-by: rubenfiszel <275584+rubenfiszel@users.noreply.github.com>	2025-02-17 15:41:06 +01:00
Ruben Fiszel	0208f53541	fix: windmill_admin has implicit bypass rls on v2_job even if role not set	2025-02-17 15:20:39 +01:00
Ruben Fiszel	3493185e2f	nits	2025-02-17 14:34:22 +01:00
Ruben Fiszel	3535016608	improve version detection from source	2025-02-17 11:49:06 +01:00
@@ -1 +1 @@
 .463.2
 .463.4