kalugin66/windmill
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

prevent sql migration modal from closing when next migration arrives (#7764)

Browse Source 
* fix: prevent sql migration modal from closing when next migration arrives

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* nit

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
centdix
2026-02-03 18:40:41 +01:00
committed by GitHub
parent 3b5c1657c7
commit 2e470816ed
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cli/src/commands/app/dev.ts
View File

@@ -215,6 +215,7 @@ const createHTML = (jsPath: string, cssPath: string) => `
// SQL Migration Modal handling
let pendingSqlMigration = null;
let sqlWebSocket = null;
let closeModalTimeout = null;
function initSqlWebSocket() {
const wsProtocol = location.protocol === 'https:' ? 'wss:' : 'ws:';
@@ -236,12 +237,19 @@ const createHTML = (jsPath: string, cssPath: string) => `
}
function showSqlModal(data) {
// Cancel any pending close from a previous migration's success
if (closeModalTimeout) {
clearTimeout(closeModalTimeout);
closeModalTimeout = null;
}
pendingSqlMigration = data;
document.getElementById('sql-file-name').textContent = data.fileName;
document.getElementById('sql-datatable').textContent = data.datatable || 'Not configured';
document.getElementById('sql-content').textContent = data.sql;
document.getElementById('sql-result').innerHTML = '';
document.getElementById('sql-result').className = 'sql-result';
document.getElementById('apply-sql-btn').disabled = !data.datatable;
document.getElementById('apply-sql-btn').textContent = 'Apply SQL';
document.getElementById('sql-modal-overlay').classList.add('visible');
}
@@ -282,7 +290,11 @@ const createHTML = (jsPath: string, cssPath: string) => `
resultDiv.className = 'sql-result success';
resultDiv.innerHTML = '<strong>Success!</strong> SQL applied and file deleted.';
// Auto-close after success (don't send skip since server already handled it)
setTimeout(() => closeSqlModal(false), 1500);
// Save timeout ID so it can be cancelled if a new migration arrives
closeModalTimeout = setTimeout(() => {
closeModalTimeout = null;
closeSqlModal(false);
}, 1500);
}
}