Add warning for omitted obscured jobs (#3790)

* Add warning for omitted obscured jobs

* Update RunsTable.svelte

---------

Co-authored-by: Ruben Fiszel <ruben@windmill.dev>
This commit is contained in:
wendrul
2024-05-22 21:14:52 +02:00
committed by GitHub
parent 92c93a029a
commit 1d2d9ebadf
2 changed files with 16 additions and 0 deletions

View File

@@ -4,10 +4,14 @@
import VirtualList from 'svelte-tiny-virtual-list'
import { createEventDispatcher, onMount } from 'svelte'
import Tooltip from '../Tooltip.svelte'
import { AlertTriangle } from 'lucide-svelte'
import Popover from '../Popover.svelte'
import { workspaceStore } from '$lib/stores'
//import InfiniteLoading from 'svelte-infinite-loading'
export let jobs: Job[] | undefined = undefined
export let externalJobs: Job[] = []
export let omittedObscuredJobs: boolean
export let showExternalJobs: boolean = false
export let selectedId: string | undefined = undefined
export let selectedWorkspace: string | undefined = undefined
@@ -167,6 +171,16 @@
>
</div>
</div>
{:else if $workspaceStore !== 'admins' && omittedObscuredJobs}
<div class="w-1/12 text-2xs flex flex-row">
{jobs && jobCountString(jobs.length)}
<Popover>
<AlertTriangle size={16} class="ml-0.5 text-yellow-500"/>
<svelte:fragment slot="text">
Too specific filtering may have caused the omission of obscured jobs. This is done for security reasons. To see obscured jobs, try removing some filters.
</svelte:fragment>
</Popover>
</div>
{:else}
<div class="w-1/12 text-2xs">{jobs && jobCountString(jobs.length)}</div>
{/if}

View File

@@ -599,6 +599,7 @@
<RunsTable
{jobs}
externalJobs={externalJobs ?? []}
omittedObscuredJobs={extendedJobs?.omitted_obscured_jobs ?? false}
showExternalJobs={!graphIsRunsChart}
activeLabel={label}
bind:selectedId
@@ -825,6 +826,7 @@
activeLabel={label}
{jobs}
externalJobs={externalJobs ?? []}
omittedObscuredJobs={extendedJobs?.omitted_obscured_jobs ?? false}
showExternalJobs={!graphIsRunsChart}
bind:selectedId
bind:selectedWorkspace