Fix ghost image showing on media player drag (#1922)
* fix: ghost image showing on media player drag * fix: add missing space * fix: access Image from window object
This commit is contained in:
committed by
GitHub
parent
5619f1805b
commit
24969c87f3
@@ -604,7 +604,7 @@ function renderPlayerControls (state) {
|
|||||||
<div
|
<div
|
||||||
key='scrub-bar'
|
key='scrub-bar'
|
||||||
className='scrub-bar'
|
className='scrub-bar'
|
||||||
draggable
|
draggable='true'
|
||||||
onMouseMove={handleScrubPreview}
|
onMouseMove={handleScrubPreview}
|
||||||
onMouseOut={clearPreview}
|
onMouseOut={clearPreview}
|
||||||
onDragStart={handleDragStart}
|
onDragStart={handleDragStart}
|
||||||
@@ -765,24 +765,15 @@ function renderPlayerControls (state) {
|
|||||||
))
|
))
|
||||||
}
|
}
|
||||||
|
|
||||||
return (
|
const emptyImage = new window.Image(0, 0)
|
||||||
<div
|
emptyImage.src = 'data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs%3D'
|
||||||
key='controls' className='controls'
|
|
||||||
onMouseEnter={dispatcher('mediaControlsMouseEnter')}
|
|
||||||
onMouseLeave={dispatcher('mediaControlsMouseLeave')}
|
|
||||||
>
|
|
||||||
{elements}
|
|
||||||
{renderCastOptions(state)}
|
|
||||||
{renderSubtitleOptions(state)}
|
|
||||||
{renderAudioTrackOptions(state)}
|
|
||||||
</div>
|
|
||||||
)
|
|
||||||
|
|
||||||
function handleDragStart (e) {
|
function handleDragStart (e) {
|
||||||
// Prevent the cursor from changing, eg to a green + icon on Mac
|
|
||||||
if (e.dataTransfer) {
|
if (e.dataTransfer) {
|
||||||
const dt = e.dataTransfer
|
const dt = e.dataTransfer
|
||||||
|
// Prevent the cursor from changing, eg to a green + icon on Mac
|
||||||
dt.effectAllowed = 'none'
|
dt.effectAllowed = 'none'
|
||||||
|
// Prevent ghost image
|
||||||
|
dt.setDragImage(emptyImage, 0, 0)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -835,6 +826,19 @@ function renderPlayerControls (state) {
|
|||||||
function handleAudioTracks (e) {
|
function handleAudioTracks (e) {
|
||||||
dispatch('toggleAudioTracksMenu')
|
dispatch('toggleAudioTracksMenu')
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
<div
|
||||||
|
key='controls' className='controls'
|
||||||
|
onMouseEnter={dispatcher('mediaControlsMouseEnter')}
|
||||||
|
onMouseLeave={dispatcher('mediaControlsMouseLeave')}
|
||||||
|
>
|
||||||
|
{elements}
|
||||||
|
{renderCastOptions(state)}
|
||||||
|
{renderSubtitleOptions(state)}
|
||||||
|
{renderAudioTrackOptions(state)}
|
||||||
|
</div>
|
||||||
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
function renderPreview (state) {
|
function renderPreview (state) {
|
||||||
|
|||||||
Reference in New Issue
Block a user