From 24969c87f31b51bd6c6a43072fdb169dab9918ad Mon Sep 17 00:00:00 2001
From: Vincenzo De Petris <37916223+vincendep@users.noreply.github.com>
Date: Thu, 23 Sep 2021 03:10:30 +0200
Subject: [PATCH] Fix ghost image showing on media player drag (#1922)

* fix: ghost image showing on media player drag

* fix: add missing space

* fix: access Image from window object
---
 src/renderer/pages/player-page.js | 34 +++++++++++++++++--------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/src/renderer/pages/player-page.js b/src/renderer/pages/player-page.js
index bcf3bbae..9ebfa9ab 100644
--- a/src/renderer/pages/player-page.js
+++ b/src/renderer/pages/player-page.js
@@ -604,7 +604,7 @@ function renderPlayerControls (state) {
       <div
         key='scrub-bar'
         className='scrub-bar'
-        draggable
+        draggable='true'
         onMouseMove={handleScrubPreview}
         onMouseOut={clearPreview}
         onDragStart={handleDragStart}
@@ -765,24 +765,15 @@ function renderPlayerControls (state) {
     ))
   }
 
-  return (
-    <div
-      key='controls' className='controls'
-      onMouseEnter={dispatcher('mediaControlsMouseEnter')}
-      onMouseLeave={dispatcher('mediaControlsMouseLeave')}
-    >
-      {elements}
-      {renderCastOptions(state)}
-      {renderSubtitleOptions(state)}
-      {renderAudioTrackOptions(state)}
-    </div>
-  )
-
+  const emptyImage = new window.Image(0, 0)
+  emptyImage.src = 'data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs%3D'
   function handleDragStart (e) {
-    // Prevent the cursor from changing, eg to a green + icon on Mac
     if (e.dataTransfer) {
       const dt = e.dataTransfer
+      // Prevent the cursor from changing, eg to a green + icon on Mac
       dt.effectAllowed = 'none'
+      // Prevent ghost image
+      dt.setDragImage(emptyImage, 0, 0)
     }
   }
 
@@ -835,6 +826,19 @@ function renderPlayerControls (state) {
   function handleAudioTracks (e) {
     dispatch('toggleAudioTracksMenu')
   }
+
+  return (
+    <div
+      key='controls' className='controls'
+      onMouseEnter={dispatcher('mediaControlsMouseEnter')}
+      onMouseLeave={dispatcher('mediaControlsMouseLeave')}
+    >
+      {elements}
+      {renderCastOptions(state)}
+      {renderSubtitleOptions(state)}
+      {renderAudioTrackOptions(state)}
+    </div>
+  )
 }
 
 function renderPreview (state) {