Files
windmill/cli/test/preview.test.ts
Ruben Fiszel 31d6660d56 feat: script module mode with CLI sync, preview, and WAC UI improvements (#8380)
* feat: add script module mode with folder model for Bun and Python

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: add missing modules field to RawCode in bun_executor

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* sqlx

* feat: enrich WAC templates with checkpoint and replay semantics

Add prominent comments explaining that all computation must happen
inside task/step/taskScript or it will be replayed on resume/retry.
Clarify that waitForApproval does not hold a worker and that
approve/reject URLs are available in the timeline step details.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(cli): script module sync idempotency, per-module hash tracking, and preview support

- Fix pull→push idempotency: use `??` instead of `||` for module lock
  field so empty strings are preserved (matches API's `lock: ""`)
- Add per-module hash tracking in wmill-lock.yaml following the flow
  inline script pattern (SCRIPT_TOP_HASH + per-module subpath hashes)
- Selective module lock regeneration: only regenerate locks for modules
  whose content actually changed, not all modules
- Use unfiltered rawWorkspaceDependencies for module hashes to match
  what updateModuleLocks passes to fetchScriptLock
- Show changed module names in stale script output for clarity
- Add module support to `script preview` command: read modules from
  __mod/ folder and pass them in the preview API request
- Add preview tests for taskScript pattern (flat and folder layout)
- Update test assertion for module stale detection output

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat(frontend): WAC UI improvements — reorder templates, module tab rename, import consolidation

- Reorder WAC template buttons: TypeScript before Python in
  ScriptBuilder, CreateActionsScript, and CreateActionsFlow
- Remove dropdown items from +Script button (simplify to direct link)
- Move "Import Workflow-as-Code" to +Flow dropdown with dedicated drawer
- Add module tab rename: pencil icon on hover opens popover with
  validation, fixed-width icon container prevents layout shift

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: remaining module-mode changes from working branch

- Backend parser updates for WAC detection
- CLI sync/types updates for raw app path and module support
- Frontend UI polish (Dev.svelte, ScriptRow, script hash page)
- Test fixture updates

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* test(cli): add test for module modification detection in generate-metadata

Verifies that modifying a single module file re-triggers stale
detection and only the changed module is listed, not all modules.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(backend): critical fixes from PR review

- Fix hardcoded dev path in bun_executor.rs WAC v2 wrapper — use
  "windmill-client" import instead of absolute filesystem path
- Fix missed no_main_func → auto_kind rename in parser TS test
- Add modules column to clone_script SQL (windmill-common and
  windmill-api-workspaces) so cloned scripts retain their modules
- Add modules: None to RawCode structs in worker tests
- Restore complete sqlx cache (merge main's cache + our new queries)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(backend): fix clone warning treated as error in CI

Change `.clone()` on double reference to `*k` dereference in
scripts.rs hash implementation. Update sqlx cache with new query
hashes from modified clone_script SQL.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(frontend): use published parser wasm versions for CI build

The local file:// paths for windmill-parser-wasm-py and
windmill-parser-wasm-ts don't exist in the Cloudflare Pages build
environment. Revert to published npm versions (1.655.0).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(frontend): update parser wasm packages to 1.657.2

Use newly published windmill-parser-wasm-ts and windmill-parser-wasm-py
v1.657.2 which include auto_kind/WAC detection changes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(frontend): regenerate package-lock.json for npm ci compatibility

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(frontend): use main's lockfile as base, update only parser wasm packages

Regenerating package-lock.json from scratch pulled different dependency
versions causing svelte-check type errors. Instead, start from main's
lockfile and only update the two changed packages.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(backend): add modules column to fetch_script_for_update query

The Script<SR> struct has a modules field (FromRow), but
fetch_script_for_update didn't SELECT modules, causing a runtime
error "no column found for name: modules" when the worker processed
dependency jobs. This was the root cause of the relock_skip test
timeout.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(backend): fix script module execution for Python and Bun

- Fix modules not passed through job queue: inject _MODULES into
  PushArgs.extra when pushing Code jobs so worker can extract them
- Fix Python module imports: use relative imports (from .helper)
  and add sys.path.insert for module directory in wrapper
- Fix Python tests: use relative imports and empty lock to prevent
  pip from resolving module names as packages
- Add local file check in Bun loader for module resolution
- Ignore Bun module test (bundle mode loader integration tracked
  separately)
- Add missing modules column to fetch_script_for_update query

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(backend): remove unnecessary empty lock in Python module tests

Relative imports (from .helper) are not parsed as pip packages,
so the empty lock workaround is not needed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(backend): fix module execution for Python and Bun — all tests pass

Python modules:
- Use relative imports (from .helper import greet) since scripts run
  as packages
- Add sys.path.insert for module directory in wrapper to ensure local
  modules take precedence over pip packages with same name

Bun modules:
- Use bundled output (./out/main.js) as wrapper import when modules
  are present — the bundled output has module content inlined by
  Bun.build, avoiding runtime loader resolution issues
- Add local file check in loader.bun.js onResolve to short-circuit
  API URL resolution for module files on disk

Job queue:
- Inject _MODULES into PushArgs.extra when pushing Code jobs so
  the worker can extract them at execution time

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor: address PR review — simplify, fix correctness, remove dead code

Critical fixes:
- Replace all CLI `no_main_func` references with `auto_kind` (string)
  to match the backend migration and API changes
- Remove duplicated `compute_python_module_dir` in worker.rs, use
  the canonical version from python_executor.rs

High priority:
- Auto-create `__init__.py` in intermediate directories for nested
  Python modules so imports like `from .utils.math import add` work
  without users manually creating __init__.py files
- Remove redundant `sys_path_insert` — relative imports use Python's
  package system, not sys.path

Medium:
- Fix lock file base name extraction: use regex to strip only the
  final extension (`.replace(/\.[^.]+$/, '')`) instead of `indexOf(".")`
  which breaks for files like `helper.test.ts`

Simplification:
- Remove dead `{#if false}` Popover block in ScriptEditor.svelte
- Guard loader.bun.js local file check to only run for relative paths
  (matching the Windows loader pattern)
- Add clarifying comment on Bun dual mechanism (build + run phases)
- Add maintenance comment on manual Hash impl for NewScript

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: final review fixes — stale cleanup, baseName, auto_kind export

- Fix sync.ts baseName extraction using indexOf(".") → regex
  (same fix as script.ts/metadata.ts, missed this instance)
- Add stale module file cleanup in writeModulesToDisk: removes files
  from __mod/ that are no longer in the modules map before writing,
  fixing the pull→push cycle that couldn't delete modules
- Log warning when _MODULES serialization fails in job push instead
  of silently dropping modules
- Use strict equality (===) for auto_kind comparison
- Exclude auto_kind from workspace export — it is auto-detected by
  the parser at deploy time from script content

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(cli): remove auto_kind from push, comparison, and metadata

auto_kind is auto-detected by the parser at deploy time, so the CLI
should not send it, compare it, or write it to script.yaml.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove erroneously added backend/backend/.sqlx directory

Duplicate .sqlx cache was committed at the wrong nested path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address PR review feedback + fix CI dead_code warning

Frontend (ScriptEditor.svelte):
- Fix switchToMain() missing lastSyncedCode update — prevents stale
  code sync on external changes while editing a module tab
- Fix formatAction saving module code to main script's localStorage
  draft — now saves main code when on a module tab
- Fix non-null assertion on inferModuleLang in renameModule — fall
  back to original language instead of force unwrap
- Remove redundant activeModuleTab truthy check in runTest

CLI (script.ts):
- Clean up empty directories after removing stale module files in
  writeModulesToDisk

Backend:
- Add path traversal guard in write_module_files — reject module
  paths containing ".."
- Fix dead_code warning on auto_kind field in workspace export struct

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat(frontend): improve auto_kind UX + address review findings

- Rename "Include without main function" toggle to "Include library
  scripts" in script list (ItemsList.svelte)
- Update NoMainFuncBadge: "No main" → "Library" with clearer tooltip
- Filter module file extensions by main script language — Python
  scripts only allow .py modules, TypeScript only .ts, etc.
- Split flushModuleState into flushModuleContent (no UI side-effect)
  and flushModuleState (flush + reset tab), reducing duplication
- Dynamic placeholder and hint text in add module popover based on
  main script language

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-17 01:20:09 +00:00

494 lines
14 KiB
TypeScript

import { expect, test } from "bun:test";
import { mkdir, writeFile } from "node:fs/promises";
import { withTestBackend } from "./test_backend.ts";
// =============================================================================
// PREVIEW COMMAND INTEGRATION TESTS
// Tests for `wmill script preview` and `wmill flow preview` commands
//
// These tests require a backend to run. Run with:
// deno test --allow-all test/preview.test.ts
//
// The tests cover:
// - Regular script preview (non-codebase)
// - Codebase script preview (CJS format)
// - Codebase script preview (ESM format)
// - Codebase script preview with assets (tar bundle)
// - Codebase script preview with ESM + tar
// - Flow preview
// =============================================================================
// Helper to create a wmill.yaml config file
async function createWmillConfig(
tempDir: string,
config: {
defaultTs?: "bun" | "deno";
codebases?: Array<{
relative_path: string;
includes?: string[];
format?: "cjs" | "esm";
assets?: Array<{ from: string; to: string }>;
}>;
}
): Promise<void> {
let yamlContent = `defaultTs: ${config.defaultTs ?? "bun"}\n`;
if (config.codebases && config.codebases.length > 0) {
yamlContent += "codebases:\n";
for (const cb of config.codebases) {
yamlContent += ` - relative_path: ${cb.relative_path}\n`;
yamlContent += " includes:\n";
for (const inc of cb.includes ?? ["**"]) {
yamlContent += ` - "${inc}"\n`;
}
if (cb.format) {
yamlContent += ` format: ${cb.format}\n`;
}
if (cb.assets && cb.assets.length > 0) {
yamlContent += " assets:\n";
for (const asset of cb.assets) {
yamlContent += ` - from: ${asset.from}\n`;
yamlContent += ` to: ${asset.to}\n`;
}
}
}
}
await writeFile(`${tempDir}/wmill.yaml`, yamlContent, "utf-8");
}
// Helper to create a script file with metadata
async function createScript(
tempDir: string,
path: string,
content: string,
metadata?: {
summary?: string;
description?: string;
}
): Promise<void> {
const dir = `${tempDir}/${path.substring(0, path.lastIndexOf("/"))}`;
await mkdir(dir, { recursive: true });
await writeFile(`${tempDir}/${path}`, content, "utf-8");
// Create metadata file
const metaPath = path.replace(/\.[^.]+$/, ".script.yaml");
const metaContent = `summary: "${metadata?.summary ?? "Test script"}"
description: "${metadata?.description ?? "Test script description"}"
lock: ""
schema:
$schema: "https://json-schema.org/draft/2020-12/schema"
type: object
properties:
name:
type: string
default: "World"
required: []
`;
await writeFile(`${tempDir}/${metaPath}`, metaContent, "utf-8");
}
// Helper to create a flow directory with flow.yaml
async function createFlow(
tempDir: string,
flowPath: string,
options: {
summary: string;
scriptContent: string;
}
): Promise<void> {
const dir = `${tempDir}/${flowPath}`;
await mkdir(dir, { recursive: true });
const flowYaml = `summary: "${options.summary}"
description: "Test flow"
value:
modules:
- id: "a"
value:
type: "rawscript"
language: "bun"
content: |
${options.scriptContent.split("\n").map(line => ` ${line}`).join("\n")}
schema:
$schema: "https://json-schema.org/draft/2020-12/schema"
type: object
properties:
name:
type: string
default: "World"
required: []
`;
await writeFile(`${dir}/flow.yaml`, flowYaml, "utf-8");
}
// =============================================================================
// SCRIPT PREVIEW TESTS
// =============================================================================
test("script preview: regular script (non-codebase)", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, { defaultTs: "bun" });
await createScript(
tempDir,
"f/test/simple_script.ts",
`export function main(name: string = "World") {
return \`Hello, \${name}!\`;
}`
);
const result = await backend.runCLICommand(
["script", "preview", "f/test/simple_script.ts"],
tempDir
);
expect(result.code).toEqual(0);
expect(result.stdout + result.stderr).toContain("Hello, World!");
});
});
test("script preview: codebase script (CJS)", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, {
defaultTs: "bun",
codebases: [{ relative_path: "f/codebase", includes: ["**"] }],
});
await createScript(
tempDir,
"f/codebase/cjs_script.ts",
`export function main(name: string = "World") {
console.log("CJS codebase script running");
return \`Hello from CJS codebase, \${name}!\`;
}`
);
const result = await backend.runCLICommand(
["script", "preview", "f/codebase/cjs_script.ts"],
tempDir
);
expect(result.code).toEqual(0);
expect(result.stdout + result.stderr).toContain("Hello from CJS codebase, World!");
});
});
test("script preview: codebase script (ESM)", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, {
defaultTs: "bun",
codebases: [{ relative_path: "f/codebase_esm", includes: ["**"], format: "esm" }],
});
await createScript(
tempDir,
"f/codebase_esm/esm_script.ts",
`export function main(name: string = "World") {
console.log("ESM codebase script running");
return \`Hello from ESM codebase, \${name}!\`;
}`
);
const result = await backend.runCLICommand(
["script", "preview", "f/codebase_esm/esm_script.ts"],
tempDir
);
expect(result.code).toEqual(0);
expect(result.stdout + result.stderr).toContain("Hello from ESM codebase, World!");
});
});
test("script preview: codebase script with assets (tar)", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, {
defaultTs: "bun",
codebases: [{
relative_path: "f/codebase_tar",
includes: ["**"],
assets: [{ from: "f/codebase_tar/data.json", to: "data.json" }],
}],
});
// Create asset file
await mkdir(`${tempDir}/f/codebase_tar`, { recursive: true });
await writeFile(
`${tempDir}/f/codebase_tar/data.json`,
JSON.stringify({ message: "Hello from asset!" }),
"utf-8"
);
await createScript(
tempDir,
"f/codebase_tar/tar_script.ts",
`import * as fs from "fs";
export function main(name: string = "World") {
console.log("Tar codebase script running");
const data = fs.readFileSync("data.json", "utf-8");
const parsed = JSON.parse(data);
return \`Hello \${name}! Asset says: \${parsed.message}\`;
}`
);
const result = await backend.runCLICommand(
["script", "preview", "f/codebase_tar/tar_script.ts"],
tempDir
);
expect(result.code).toEqual(0);
expect(result.stdout + result.stderr).toContain("Hello World! Asset says: Hello from asset!");
});
});
test("script preview: codebase script ESM + tar (assets)", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, {
defaultTs: "bun",
codebases: [{
relative_path: "f/codebase_esm_tar",
includes: ["**"],
format: "esm",
assets: [{ from: "f/codebase_esm_tar/config.json", to: "config.json" }],
}],
});
// Create asset file
await mkdir(`${tempDir}/f/codebase_esm_tar`, { recursive: true });
await writeFile(
`${tempDir}/f/codebase_esm_tar/config.json`,
JSON.stringify({ setting: "esm_tar_value" }),
"utf-8"
);
await createScript(
tempDir,
"f/codebase_esm_tar/esm_tar_script.ts",
`import * as fs from "fs";
export function main(name: string = "World") {
console.log("ESM + tar codebase script running");
const config = fs.readFileSync("config.json", "utf-8");
const parsed = JSON.parse(config);
return \`Hello \${name}! Config setting: \${parsed.setting}\`;
}`
);
const result = await backend.runCLICommand(
["script", "preview", "f/codebase_esm_tar/esm_tar_script.ts"],
tempDir
);
expect(result.code).toEqual(0);
expect(result.stdout + result.stderr).toContain("Hello World! Config setting: esm_tar_value");
});
});
test("script preview: codebase with imports (simulates ../shared layout)", async () => {
await withTestBackend(async (backend, tempDir) => {
// This test simulates a codebase that could be in a parent directory.
// The structure is:
// tempDir/
// wmill.yaml (codebase at ".")
// f/
// lib/
// helper.ts (shared module)
// main_script.ts (imports helper)
//
// This tests that codebase bundling correctly includes imported modules,
// which is the key functionality needed for ../shared codebases during sync.
// Note: Preview requires valid windmill paths (u/, g/, f/), so we run
// from within the codebase directory.
await createWmillConfig(tempDir, {
defaultTs: "bun",
codebases: [{ relative_path: ".", includes: ["**"] }],
});
// Create helper module
await mkdir(`${tempDir}/f/lib`, { recursive: true });
await writeFile(
`${tempDir}/f/lib/helper.ts`,
`export function greet(name: string): string {
return \`Hello from shared codebase, \${name}!\`;
}`,
"utf-8"
);
// Create main script that imports the helper
await writeFile(
`${tempDir}/f/lib/main_script.ts`,
`import { greet } from "./helper";
export function main(name: string = "World") {
console.log("Running codebase script with imports");
return greet(name);
}`,
"utf-8"
);
// Create script metadata
await writeFile(
`${tempDir}/f/lib/main_script.script.yaml`,
`summary: "Test script with imports"
description: "Test script that imports from helper module"
lock: ""
schema:
$schema: "https://json-schema.org/draft/2020-12/schema"
type: object
properties:
name:
type: string
default: "World"
required: []
`,
"utf-8"
);
// Run preview - the script should be bundled with the helper module
const result = await backend.runCLICommand(
["script", "preview", "f/lib/main_script.ts"],
tempDir
);
expect(result.code).toEqual(0);
// The script should be bundled (includes the helper) and run successfully
expect(
result.stdout + result.stderr,
).toContain("Hello from shared codebase, World!");
});
});
// =============================================================================
// SCRIPT WITH MODULES PREVIEW TESTS
// =============================================================================
test("script preview: script with modules (taskScript pattern)", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, { defaultTs: "bun" });
// Create the main script that uses taskScript to call a module
await createScript(
tempDir,
"f/test/wac_script.ts",
`import { task, taskScript, workflow } from "windmill-client";
const helper = taskScript("./helper.ts");
const process = task(async (x: string): Promise<string> => {
return \`processed: \${x}\`;
});
export const main = workflow(async (x: string = "test") => {
const a = await process(x);
const b = await helper({ a });
return { processed: a, helper_result: b };
});`
);
// Create the module file in __mod/ folder
const modDir = `${tempDir}/f/test/wac_script__mod`;
await mkdir(modDir, { recursive: true });
await writeFile(
`${modDir}/helper.ts`,
`export function main(a: string): string {
return \`helper got: \${a}\`;
}`,
"utf-8"
);
const result = await backend.runCLICommand(
["script", "preview", "f/test/wac_script.ts"],
tempDir
);
expect(result.code).toEqual(0);
const output = result.stdout + result.stderr;
expect(output).toContain("processed: test");
expect(output).toContain("helper got:");
});
});
test("script preview: script with modules (folder layout)", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, { defaultTs: "bun" });
// Create folder layout: my_script__mod/script.ts + my_script__mod/helper.ts
const modDir = `${tempDir}/f/test/folder_wac__mod`;
await mkdir(modDir, { recursive: true });
// Entry point script
await writeFile(
`${modDir}/script.ts`,
`import { task, taskScript, workflow } from "windmill-client";
const helper = taskScript("./helper.ts");
export const main = workflow(async (name: string = "World") => {
const result = await helper({ name });
return { greeting: result };
});`,
"utf-8"
);
// Module file
await writeFile(
`${modDir}/helper.ts`,
`export function main(name: string): string {
return \`Hello from module, \${name}!\`;
}`,
"utf-8"
);
// Script metadata
await writeFile(
`${modDir}/script.yaml`,
`summary: "Folder layout WAC script"
description: "Test"
lock: ""
schema:
$schema: "https://json-schema.org/draft/2020-12/schema"
type: object
properties:
name:
type: string
default: "World"
required: []
`,
"utf-8"
);
const result = await backend.runCLICommand(
["script", "preview", `f/test/folder_wac__mod/script.ts`],
tempDir
);
expect(result.code).toEqual(0);
const output = result.stdout + result.stderr;
expect(output).toContain("Hello from module, World!");
});
});
// =============================================================================
// FLOW PREVIEW TESTS
// =============================================================================
test("flow preview: simple flow", async () => {
await withTestBackend(async (backend, tempDir) => {
await createWmillConfig(tempDir, { defaultTs: "bun" });
await createFlow(tempDir, "f/test/simple_flow.flow", {
summary: "Test flow",
scriptContent: `export function main(name: string = "World") { return \`Flow says: Hello, \${name}!\`; }`,
});
const result = await backend.runCLICommand(
["flow", "preview", "f/test/simple_flow.flow"],
tempDir
);
expect(result.code).toEqual(0);
expect(result.stdout + result.stderr).toContain("Flow says: Hello, World!");
});
});