* add tracing to get of authed client * internal: Trigger claude when commenting with /aider (#5783) * add claude instructions files * call claude too when using aider * fix * add draft for linear claude integration * fix: workspace preprocessor fixes * tmp ee ref * fix build * update ee ref * fix: hub script preprocessor handling * fix build * good ref --------- Co-authored-by: Ruben Fiszel <ruben@windmill.dev> Co-authored-by: centdix <40307056+centdix@users.noreply.github.com>
445 lines
15 KiB
Rust
445 lines
15 KiB
Rust
use serde::Deserialize;
|
|
use serde_json::value::RawValue;
|
|
use std::collections::HashMap;
|
|
use windmill_common::{
|
|
error::Result,
|
|
flows::FlowModuleValue,
|
|
get_latest_deployed_hash_for_path, get_latest_flow_version_info_for_path,
|
|
jobs::get_has_preprocessor_from_content_and_lang,
|
|
scripts::{get_full_hub_script_by_path, ScriptHash, ScriptLang},
|
|
triggers::{
|
|
HubOrWorkspaceId, RunnableFormat, RunnableFormatVersion, TriggerKind,
|
|
RUNNABLE_FORMAT_VERSION_CACHE,
|
|
},
|
|
utils::StripPath,
|
|
worker::to_raw_value,
|
|
FlowVersionInfo,
|
|
};
|
|
use windmill_queue::PushArgsOwned;
|
|
|
|
use crate::{db::DB, HTTP_CLIENT};
|
|
|
|
struct ScriptInfo {
|
|
has_preprocessor: Option<bool>,
|
|
language: ScriptLang,
|
|
content: String,
|
|
schema: Option<sqlx::types::Json<PartialSchema>>,
|
|
}
|
|
|
|
#[derive(Debug, Deserialize)]
|
|
struct PropertyDefinition {
|
|
r#type: Option<String>,
|
|
}
|
|
|
|
#[derive(Debug, Deserialize)]
|
|
struct PartialSchema {
|
|
properties: Option<HashMap<String, PropertyDefinition>>,
|
|
}
|
|
|
|
#[derive(Debug, Clone, Eq, PartialEq, Hash)]
|
|
pub enum RunnableId {
|
|
FlowPath(String),
|
|
ScriptId(ScriptId),
|
|
HubScript(String),
|
|
}
|
|
|
|
impl RunnableId {
|
|
pub fn from_script_hash(hash: ScriptHash) -> Self {
|
|
Self::ScriptId(ScriptId::ScriptHash(hash))
|
|
}
|
|
|
|
pub fn from_script_path(path: &str) -> Self {
|
|
if path.starts_with("hub/") {
|
|
Self::HubScript(path.to_string())
|
|
} else {
|
|
Self::ScriptId(ScriptId::ScriptPath(path.to_string()))
|
|
}
|
|
}
|
|
|
|
pub fn from_flow_path(path: &str) -> Self {
|
|
Self::FlowPath(path.to_string())
|
|
}
|
|
}
|
|
|
|
#[derive(Debug, Clone, Eq, PartialEq, Hash)]
|
|
pub enum ScriptId {
|
|
ScriptPath(String),
|
|
ScriptHash(ScriptHash),
|
|
}
|
|
|
|
impl ScriptId {
|
|
async fn get_script_hash(self, workspace_id: &str, db: &DB) -> Result<i64> {
|
|
let hash = match self {
|
|
ScriptId::ScriptPath(path) => {
|
|
let info = get_latest_deployed_hash_for_path(db, workspace_id, &path).await?;
|
|
info.hash
|
|
}
|
|
ScriptId::ScriptHash(hash) => hash.0,
|
|
};
|
|
|
|
Ok(hash)
|
|
}
|
|
}
|
|
|
|
async fn get_script_info(
|
|
db: &DB,
|
|
workspace_id: &str,
|
|
hash: i64,
|
|
) -> std::result::Result<ScriptInfo, sqlx::Error> {
|
|
sqlx::query_as!(ScriptInfo, "SELECT has_preprocessor, language as \"language: _\", content, schema as \"schema: _\" FROM script WHERE workspace_id = $1 AND hash = $2", workspace_id, hash)
|
|
.fetch_one(db)
|
|
.await
|
|
}
|
|
|
|
fn runnable_format_from_schema_without_preprocessor(
|
|
trigger_kind: &TriggerKind,
|
|
schema: Option<sqlx::types::Json<PartialSchema>>,
|
|
) -> RunnableFormat {
|
|
match trigger_kind {
|
|
TriggerKind::Mqtt
|
|
if schema.as_ref().is_some_and(|schema| {
|
|
schema.properties.as_ref().is_some_and(|properties| {
|
|
properties.iter().any(|(key, def)| {
|
|
key == "payload" && def.r#type.as_ref().is_some_and(|t| t == "array")
|
|
})
|
|
})
|
|
}) =>
|
|
{
|
|
RunnableFormat { version: RunnableFormatVersion::V1, has_preprocessor: false }
|
|
}
|
|
TriggerKind::Kafka | TriggerKind::Nats
|
|
if schema.as_ref().is_some_and(|schema| {
|
|
schema
|
|
.properties
|
|
.as_ref()
|
|
.is_some_and(|properties| properties.keys().any(|key| key == "msg"))
|
|
}) =>
|
|
{
|
|
RunnableFormat { version: RunnableFormatVersion::V1, has_preprocessor: false }
|
|
}
|
|
_ => RunnableFormat { version: RunnableFormatVersion::V2, has_preprocessor: false },
|
|
}
|
|
}
|
|
|
|
fn runnable_format_from_preprocessor_args(
|
|
args: Option<Vec<windmill_parser::Arg>>,
|
|
) -> RunnableFormat {
|
|
if let Some(args) = args {
|
|
if args.iter().any(|arg| arg.name == "wm_trigger")
|
|
|| (args.len() > 0 && args.iter().all(|arg| arg.name != "event"))
|
|
{
|
|
RunnableFormat { version: RunnableFormatVersion::V1, has_preprocessor: true }
|
|
} else {
|
|
RunnableFormat { version: RunnableFormatVersion::V2, has_preprocessor: true }
|
|
}
|
|
} else {
|
|
RunnableFormat { version: RunnableFormatVersion::V2, has_preprocessor: true }
|
|
}
|
|
}
|
|
|
|
enum PreprocessorInfo {
|
|
Preprocessor { content: String, language: ScriptLang },
|
|
NoPreprocessor { schema: Option<sqlx::types::Json<PartialSchema>> },
|
|
}
|
|
|
|
#[derive(Debug, Deserialize)]
|
|
struct FlowInfo {
|
|
preprocessor_module: Option<sqlx::types::Json<FlowModuleValue>>,
|
|
schema: Option<sqlx::types::Json<PartialSchema>>,
|
|
}
|
|
|
|
fn get_preprocessor_args_from_content_and_language(
|
|
content: &str,
|
|
language: &ScriptLang,
|
|
) -> Result<Option<Vec<windmill_parser::Arg>>> {
|
|
let args = match language {
|
|
ScriptLang::Bun | ScriptLang::Bunnative | ScriptLang::Deno | ScriptLang::Nativets => {
|
|
let args = windmill_parser_ts::parse_deno_signature(
|
|
&content,
|
|
true,
|
|
false,
|
|
Some("preprocessor".to_string()),
|
|
)?;
|
|
Some(args.args)
|
|
}
|
|
ScriptLang::Python3 => {
|
|
let args = windmill_parser_py::parse_python_signature(
|
|
&content,
|
|
Some("preprocessor".to_string()),
|
|
false,
|
|
)?;
|
|
Some(args.args)
|
|
}
|
|
_ => None,
|
|
};
|
|
Ok(args)
|
|
}
|
|
|
|
pub async fn get_runnable_format(
|
|
runnable_id: RunnableId,
|
|
workspace_id: &str,
|
|
db: &DB,
|
|
trigger_kind: &TriggerKind,
|
|
) -> Result<RunnableFormat> {
|
|
let (key, preprocessor_info) = match runnable_id {
|
|
RunnableId::HubScript(path) => {
|
|
let Some(version) = path.split("/").nth(1) else {
|
|
return Err(windmill_common::error::Error::internal_err(
|
|
"Invalid hub script path".to_string(),
|
|
));
|
|
};
|
|
|
|
let version = match version.parse::<i64>() {
|
|
Ok(version) => version,
|
|
Err(_) => {
|
|
return Err(windmill_common::error::Error::internal_err(
|
|
"Invalid hub script version".to_string(),
|
|
));
|
|
}
|
|
};
|
|
|
|
let key = (HubOrWorkspaceId::Hub, version, trigger_kind.clone());
|
|
|
|
let runnable_format = RUNNABLE_FORMAT_VERSION_CACHE.get(&key);
|
|
|
|
if let Some(runnable_format) = runnable_format {
|
|
tracing::debug!("Using cached runnable format for hub script {path}");
|
|
return Ok(runnable_format);
|
|
}
|
|
|
|
let hub_script =
|
|
get_full_hub_script_by_path(StripPath(path.to_string()), &HTTP_CLIENT, Some(db))
|
|
.await?;
|
|
|
|
let has_preprocessor = get_has_preprocessor_from_content_and_lang(
|
|
&hub_script.content,
|
|
&hub_script.language,
|
|
)?;
|
|
|
|
let partial_schema = serde_json::from_str(hub_script.schema.get())?;
|
|
|
|
(
|
|
key,
|
|
if has_preprocessor {
|
|
PreprocessorInfo::Preprocessor {
|
|
content: hub_script.content,
|
|
language: hub_script.language,
|
|
}
|
|
} else {
|
|
PreprocessorInfo::NoPreprocessor {
|
|
schema: Some(sqlx::types::Json(partial_schema)),
|
|
}
|
|
},
|
|
)
|
|
}
|
|
RunnableId::FlowPath(path) => {
|
|
let FlowVersionInfo { version, .. } =
|
|
get_latest_flow_version_info_for_path(db, workspace_id, &path, true).await?;
|
|
|
|
let key = (
|
|
HubOrWorkspaceId::WorkspaceId(workspace_id.to_string()),
|
|
version,
|
|
trigger_kind.clone(),
|
|
);
|
|
|
|
let runnable_format = RUNNABLE_FORMAT_VERSION_CACHE.get(&key);
|
|
|
|
if let Some(runnable_format) = runnable_format {
|
|
tracing::debug!("Using cached runnable format for flow {path}");
|
|
return Ok(runnable_format);
|
|
}
|
|
|
|
let flow_info = sqlx::query_as!(
|
|
FlowInfo,
|
|
"SELECT
|
|
value->'preprocessor_module'->'value' as \"preprocessor_module: _\",
|
|
schema as \"schema: _\"
|
|
FROM flow_version
|
|
WHERE
|
|
path = $1
|
|
AND workspace_id = $2
|
|
ORDER BY created_at DESC
|
|
LIMIT 1",
|
|
path,
|
|
workspace_id,
|
|
)
|
|
.fetch_one(db)
|
|
.await?;
|
|
|
|
if let Some(preprocessor_module) = flow_info.preprocessor_module {
|
|
match preprocessor_module.0 {
|
|
FlowModuleValue::RawScript { content, language, .. } => {
|
|
(key, PreprocessorInfo::Preprocessor { content, language })
|
|
}
|
|
FlowModuleValue::Script { path, hash, .. } => {
|
|
let hash = if let Some(hash) = hash {
|
|
hash.0
|
|
} else {
|
|
let script_hash =
|
|
get_latest_deployed_hash_for_path(db, workspace_id, &path).await?;
|
|
script_hash.hash
|
|
};
|
|
let script_info = get_script_info(db, workspace_id, hash).await?;
|
|
(
|
|
key,
|
|
PreprocessorInfo::Preprocessor {
|
|
content: script_info.content,
|
|
language: script_info.language,
|
|
},
|
|
)
|
|
}
|
|
_ => {
|
|
return Err(windmill_common::error::Error::internal_err(
|
|
"Unsupported preprocessor module".to_string(),
|
|
));
|
|
}
|
|
}
|
|
} else {
|
|
(
|
|
key,
|
|
PreprocessorInfo::NoPreprocessor { schema: flow_info.schema },
|
|
)
|
|
}
|
|
}
|
|
RunnableId::ScriptId(script_id) => {
|
|
let hash = script_id.get_script_hash(workspace_id, db).await?;
|
|
let key = (
|
|
HubOrWorkspaceId::WorkspaceId(workspace_id.to_string()),
|
|
hash,
|
|
trigger_kind.clone(),
|
|
);
|
|
let runnable_format = RUNNABLE_FORMAT_VERSION_CACHE.get(&key);
|
|
|
|
if let Some(runnable_format) = runnable_format {
|
|
tracing::debug!("Using cached runnable format for script {hash}");
|
|
return Ok(runnable_format);
|
|
}
|
|
|
|
let script_info = get_script_info(db, workspace_id, hash).await?;
|
|
|
|
if script_info.has_preprocessor.unwrap_or(false) {
|
|
(
|
|
key,
|
|
PreprocessorInfo::Preprocessor {
|
|
content: script_info.content,
|
|
language: script_info.language,
|
|
},
|
|
)
|
|
} else {
|
|
(
|
|
key,
|
|
PreprocessorInfo::NoPreprocessor { schema: script_info.schema },
|
|
)
|
|
}
|
|
}
|
|
};
|
|
|
|
let runnable_format = match preprocessor_info {
|
|
PreprocessorInfo::Preprocessor { content, language } => {
|
|
let args = get_preprocessor_args_from_content_and_language(&content, &language)?;
|
|
runnable_format_from_preprocessor_args(args)
|
|
}
|
|
PreprocessorInfo::NoPreprocessor { schema } => {
|
|
runnable_format_from_schema_without_preprocessor(trigger_kind, schema)
|
|
}
|
|
};
|
|
|
|
RUNNABLE_FORMAT_VERSION_CACHE.insert(key, runnable_format);
|
|
|
|
Ok(runnable_format)
|
|
}
|
|
|
|
#[allow(dead_code)]
|
|
pub trait TriggerJobArgs<T: Clone> {
|
|
fn v1_payload_fn(payload: T) -> HashMap<String, Box<RawValue>>;
|
|
fn v2_payload_fn(payload: T) -> HashMap<String, Box<RawValue>> {
|
|
Self::v1_payload_fn(payload)
|
|
}
|
|
fn trigger_kind() -> TriggerKind;
|
|
|
|
fn build_job_args_v2(
|
|
has_preprocessor: bool,
|
|
payload: T,
|
|
info: HashMap<String, Box<RawValue>>,
|
|
) -> PushArgsOwned {
|
|
let trigger_kind = Self::trigger_kind();
|
|
let mut args = Self::v2_payload_fn(payload);
|
|
if has_preprocessor {
|
|
args.insert("kind".to_string(), to_raw_value(&trigger_kind.to_key()));
|
|
args.extend(info);
|
|
let args = HashMap::from([("event".to_string(), to_raw_value(&args))]);
|
|
PushArgsOwned { args, extra: None }
|
|
} else {
|
|
PushArgsOwned { args, extra: None }
|
|
}
|
|
}
|
|
|
|
fn build_job_args_v1(
|
|
has_preprocessor: bool,
|
|
payload: T,
|
|
info: HashMap<String, Box<RawValue>>,
|
|
) -> PushArgsOwned {
|
|
let trigger_kind = Self::trigger_kind();
|
|
let trigger_key = trigger_kind.to_key();
|
|
let args = Self::v1_payload_fn(payload);
|
|
let extra = if has_preprocessor {
|
|
Some(HashMap::from([(
|
|
"wm_trigger".to_string(),
|
|
to_raw_value(&serde_json::json!({
|
|
"kind": trigger_key,
|
|
trigger_key: info
|
|
})),
|
|
)]))
|
|
} else {
|
|
None
|
|
};
|
|
|
|
PushArgsOwned { args, extra }
|
|
}
|
|
|
|
async fn build_job_args(
|
|
runnable_path: &str,
|
|
is_flow: bool,
|
|
w_id: &str,
|
|
db: &DB,
|
|
payload: T,
|
|
info: HashMap<String, Box<RawValue>>,
|
|
) -> Result<PushArgsOwned> {
|
|
let runnable_id = if is_flow {
|
|
RunnableId::from_flow_path(runnable_path)
|
|
} else {
|
|
RunnableId::from_script_path(runnable_path)
|
|
};
|
|
Self::build_job_args_from_runnable_id(runnable_id, w_id, db, payload, info).await
|
|
}
|
|
|
|
async fn build_job_args_from_runnable_id(
|
|
runnable_id: RunnableId,
|
|
w_id: &str,
|
|
db: &DB,
|
|
payload: T,
|
|
info: HashMap<String, Box<RawValue>>,
|
|
) -> Result<PushArgsOwned> {
|
|
let runnable_format =
|
|
get_runnable_format(runnable_id, w_id, db, &Self::trigger_kind()).await?;
|
|
|
|
match runnable_format {
|
|
RunnableFormat { version: RunnableFormatVersion::V1, has_preprocessor } => {
|
|
Ok(Self::build_job_args_v1(has_preprocessor, payload, info))
|
|
}
|
|
RunnableFormat { version: RunnableFormatVersion::V2, has_preprocessor } => {
|
|
Ok(Self::build_job_args_v2(has_preprocessor, payload, info))
|
|
}
|
|
}
|
|
}
|
|
|
|
fn build_capture_payloads(
|
|
payload: T,
|
|
info: HashMap<String, Box<RawValue>>,
|
|
) -> (PushArgsOwned, PushArgsOwned) {
|
|
let main_args = Self::build_job_args_v2(false, payload.clone(), info.clone());
|
|
let preprocessor_args = Self::build_job_args_v2(true, payload, info);
|
|
(main_args, preprocessor_args)
|
|
}
|
|
}
|