5d79f33590
* Remove $$props.field usage * Rename slots to ensure no hyphen * _props * _trigger * OnSelectedIteration type correct capitalization * rename _content * Remove afterUpdate * Migrate everything to svelte 5 * array bind * Fix popover * type never * nit fixes * Fixed many trivial errors * onClick * Fix errors * use let: * nit typing * fix: wrap state_referenced_locally vars with untrack() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * Add untrack import * Fix all syntax errors due to untrack migration * Fix undefined errors * Fix more undefined errors * untrack(() => initialOpen) * svelte-ignore * Fix state_descriptors_fixed error in Chart.svelte Use $state.snapshot() to pass plain copies of data/options to Chart.js instead of $state proxies. Chart.js's listenArrayEvents tries to define property descriptors on data arrays, which Svelte 5 proxies reject. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * nit typing * Merge issue * Fix "path is not set" error in resource picker / editor * Fix InputTransformForm error when rerunning some flows * fix npm run check --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
40 lines
1.9 KiB
Plaintext
40 lines
1.9 KiB
Plaintext
# Svelte 5 Migration - Bug Report
|
|
# Testing started: 2026-03-02
|
|
|
|
## Warnings (not blocking but worth fixing)
|
|
|
|
1. [WARNING] binding_property_non_reactive in Grid.svelte:372:5
|
|
- `bind:this={moveResizes[item.id]}` is binding to a non-reactive property
|
|
- File: src/lib/components/apps/svelte-grid/Grid.svelte
|
|
- Appears multiple times in App editor
|
|
- Status: NOT FIXED (non-blocking warning)
|
|
|
|
2. [WARNING] legacy_recursive_reactive_block in RecomputeAllComponents.svelte
|
|
- Migrated `$:` reactive block that both accesses and updates the same reactive value
|
|
- File: src/lib/components/apps/editor/RecomputeAllComponents.svelte
|
|
- May cause recursive updates when converted to $effect
|
|
- Status: NOT FIXED (non-blocking warning)
|
|
|
|
3. [WARNING] ownership_invalid_mutation in SchemaForm.svelte:70:16
|
|
- Mutating unbound props (`schema`) is strongly discouraged
|
|
- Parent: src/lib/components/ApiConnectForm.svelte should use `bind:schema={...}`
|
|
- Appears when opening PostgreSQL resource creation form
|
|
- Status: NOT FIXED (non-blocking warning)
|
|
|
|
4. [WARNING] ownership_invalid_binding in InputTransformSchemaForm.svelte
|
|
- Passes `schema` to InputTransformForm.svelte with `bind:`, but parent Pane.svelte didn't declare `schema` as binding
|
|
- Appears in flow editor when adding a TypeScript step
|
|
- Status: NOT FIXED (non-blocking warning)
|
|
|
|
## Bugs
|
|
|
|
1. [BUG] state_descriptors_fixed in Chart.svelte (Queue metrics drawer)
|
|
- Error: "Property descriptors defined on `$state` objects must contain `value` and always be `enumerable`, `configurable` and `writable`."
|
|
- Triggered by: Clicking "Queue metrics" on /workers page
|
|
- File: src/lib/components/chartjs-wrappers/Chart.svelte
|
|
- Root cause: Chart.js's `listenArrayEvents` calls Object.defineProperty on data arrays that are Svelte 5 $state proxies, which reject non-standard property descriptors
|
|
- Fix: Use $state.snapshot() to pass plain copies of data and options to Chart.js
|
|
- Status: FIXED
|
|
|
|
|