From f2a8303cb9d8f90aceefec3ec17fbcecf205f90b Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Fri, 26 Apr 2024 18:18:31 +0200
Subject: [PATCH] allow other cell renderer for aggrid

---
 .../table/AppAggridExplorerTable.svelte       | 10 ++--------
 .../display/table/AppAggridTable.svelte       |  4 ++--
 .../apps/components/display/table/utils.ts    | 20 ++++++++++---------
 3 files changed, 15 insertions(+), 19 deletions(-)

diff --git a/frontend/src/lib/components/apps/components/display/table/AppAggridExplorerTable.svelte b/frontend/src/lib/components/apps/components/display/table/AppAggridExplorerTable.svelte
index d95b6013a5..4f5ca04b0d 100644
--- a/frontend/src/lib/components/apps/components/display/table/AppAggridExplorerTable.svelte
+++ b/frontend/src/lib/components/apps/components/display/table/AppAggridExplorerTable.svelte
@@ -1,10 +1,5 @@
 <script lang="ts">
-	import {
-		GridApi,
-		createGrid,
-		type IDatasource,
-		type ICellRendererParams
-	} from 'ag-grid-community'
+	import { GridApi, createGrid, type IDatasource } from 'ag-grid-community'
 	import { isObject, sendUserToast } from '$lib/utils'
 	import { createEventDispatcher, getContext } from 'svelte'
 	import type { AppViewerContext, ComponentCustomCSS } from '../../../types'
@@ -243,8 +238,7 @@
 
 		return r.map((fields) => ({
 			...fields,
-			cellRenderer: (params: ICellRendererParams) =>
-				defaultCellRenderer(params, fields.cellRendererType)
+			cellRenderer: defaultCellRenderer(fields.cellRendererType)
 		}))
 	}
 
diff --git a/frontend/src/lib/components/apps/components/display/table/AppAggridTable.svelte b/frontend/src/lib/components/apps/components/display/table/AppAggridTable.svelte
index 89f36e6452..2b1ad9ee2d 100644
--- a/frontend/src/lib/components/apps/components/display/table/AppAggridTable.svelte
+++ b/frontend/src/lib/components/apps/components/display/table/AppAggridTable.svelte
@@ -257,7 +257,7 @@
 						rowData: value,
 						columnDefs: columnDefs.map((fields) => ({
 							...fields,
-							cellRenderer: (params) => defaultCellRenderer(params, fields.cellRendererType)
+							cellRenderer: defaultCellRenderer(fields.cellRendererType)
 						})),
 						pagination: resolvedConfig?.pagination,
 						paginationAutoPageSize: resolvedConfig?.pagination,
@@ -385,7 +385,7 @@
 				rowData: value,
 				columnDefs: columnDefs.map((fields) => ({
 					...fields,
-					cellRenderer: (params) => defaultCellRenderer(params, fields.cellRendererType)
+					cellRenderer: defaultCellRenderer(fields.cellRendererType)
 				})),
 				pagination: resolvedConfig?.pagination,
 				paginationAutoPageSize: resolvedConfig?.pagination,
diff --git a/frontend/src/lib/components/apps/components/display/table/utils.ts b/frontend/src/lib/components/apps/components/display/table/utils.ts
index 8729cbef32..2d97bf5975 100644
--- a/frontend/src/lib/components/apps/components/display/table/utils.ts
+++ b/frontend/src/lib/components/apps/components/display/table/utils.ts
@@ -77,17 +77,19 @@ export function isLinkObject(value: any): value is LinkObject {
 	return value && typeof value === 'object' && 'href' in value && 'label' in value
 }
 
-export function defaultCellRenderer(params: ICellRendererParams, cellRendererType: string) {
+export function defaultCellRenderer(cellRendererType: string) {
 	if (cellRendererType === 'link') {
-		if (isLinkObject(params.value)) {
-			const value = params.value
-			return `<a href=${value.href} class="underline" target="_blank">${value.label}</a>`
-		} else if (params.value) {
-			return `<a href=${params.value} class="underline" target="_blank">${params.value}</a>`
-		} else {
-			return params.value
+		return (params: ICellRendererParams) => {
+			if (isLinkObject(params.value)) {
+				const value = params.value
+				return `<a href=${value.href} class="underline" target="_blank">${value.label}</a>`
+			} else if (params.value) {
+				return `<a href=${params.value} class="underline" target="_blank">${params.value}</a>`
+			} else {
+				return params.value
+			}
 		}
 	} else {
-		return params.value
+		return undefined
 	}
 }