From e2a053c022aabf0d6e2ff42f5b8dba259caac378 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Sun, 27 Aug 2023 16:05:46 +0200
Subject: [PATCH] fix parrallel forloop and branchall failure handling

---
 backend/windmill-worker/src/worker_flow.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/backend/windmill-worker/src/worker_flow.rs b/backend/windmill-worker/src/worker_flow.rs
index 8c0a44bc86..f149e5f1a3 100644
--- a/backend/windmill-worker/src/worker_flow.rs
+++ b/backend/windmill-worker/src/worker_flow.rs
@@ -115,7 +115,7 @@ pub async fn update_flow_status_after_job_completion_internal<
     flow: uuid::Uuid,
     job_id_for_status: &Uuid,
     w_id: &str,
-    success: bool,
+    mut success: bool,
     result: serde_json::Value,
     metrics: Option<Metrics>,
     unrecoverable: bool,
@@ -293,6 +293,7 @@ pub async fn update_flow_status_after_job_completion_internal<
                             branch_chosen: None,
                         }
                     };
+                    success = false;
                     (true, Some(new_status))
                 } else {
                     tx.commit().await?;
@@ -501,6 +502,9 @@ pub async fn update_flow_status_after_job_completion_internal<
             }
         };
 
+        // tracing::error!(
+        //     "UPDATE FLOW STATUS 3: {module:#?} {skip_failure} {is_last_step} {success}"
+        // );
         let should_continue_flow = match success {
             _ if stop_early => false,
             _ if flow_job.canceled => false,