kalugin66/windmill
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

preserve on_behalf_of by default (with prompt if no rights to do so)

Browse Source
This commit is contained in:
wendrul
2026-03-04 17:22:47 +01:00
parent d724fa6cef
commit dbbe192b3c
4 changed files with 62 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
cli/src/core/permissioned_as.ts
View File

@@ -189,13 +189,13 @@ export async function preCheckPermissionedAs(
}
}
} else if (typeStr === "flow") {
// Flow metadata may have on_behalf_of_email
const match = beforeContent.match(
/on_behalf_of_email:\s*["']?([^\s"']+)["']?/
);
if (match) {
currentOwner = match[1];
}
// Flow on_behalf_of_email is stripped during sync pull, so we can't
// reliably detect the current owner from local files. Always flag it.
wouldChangeItems.push({
path: change.path,
currentOwner: "(flow owner)",
});
continue;
} else if (typeStr === "app") {
// Apps always have on_behalf_of set - any edited app will change owner
wouldChangeItems.push({
@@ -211,12 +211,13 @@ export async function preCheckPermissionedAs(
currentOwner = match[1];
}
} else if (typeStr.endsWith("_trigger")) {
const match = beforeContent.match(
/email:\s*["']?([^\s"']+)["']?/
);
if (match) {
currentOwner = match[1];
}
// Trigger email/edited_by is stripped during sync pull, so we can't
// reliably detect the current owner from local files. Always flag it.
wouldChangeItems.push({
path: change.path,
currentOwner: "(trigger owner)",
});
continue;
}
if (currentOwner && currentOwner !== userEmail) {