Instrument logs (#3566)
* Add spans to show worker_name and job_id Always show worker_name and job_id when relevant, by creating spans that live as long as the worker and the job. * Remove redundant worker names from fn run_worker Remove the now redundant worker_name tracing, as the information now lives at the span level * Use span when spawning new thread * Instrument more pertinent functions Move spans to more pertinent functions. Remove more redundant info, and change worker_name to just worker * Change tracing subscriber to log path:line_no Change from logging target (module name usually) to file path and line number
This commit is contained in:
@@ -391,8 +391,6 @@ mount {{
|
||||
}
|
||||
|
||||
tracing::info!(
|
||||
worker_name = %worker_name,
|
||||
job_id = %job.id,
|
||||
workspace_id = %job.workspace_id,
|
||||
"started python code execution {}",
|
||||
job.id
|
||||
@@ -614,7 +612,7 @@ async fn replace_pip_secret(
|
||||
}
|
||||
let secret = get_secret_value_as_admin(db, w_id, variable).await?;
|
||||
tracing::info!(
|
||||
worker_name = %worker_name,
|
||||
worker = %worker_name,
|
||||
job_id = %job_id,
|
||||
workspace_id = %w_id,
|
||||
"found secret variable in pip requirements: {}",
|
||||
@@ -878,16 +876,12 @@ pub async fn handle_python_reqs(
|
||||
append_logs(job_id.clone(), w_id.to_string(), logs1, db).await;
|
||||
|
||||
tracing::info!(
|
||||
worker_name = %worker_name,
|
||||
job_id = %job_id,
|
||||
workspace_id = %w_id,
|
||||
"started setup python dependencies"
|
||||
);
|
||||
|
||||
let child = if !*DISABLE_NSJAIL {
|
||||
tracing::info!(
|
||||
worker_name = %worker_name,
|
||||
job_id = %job_id,
|
||||
workspace_id = %w_id,
|
||||
"starting nsjail"
|
||||
);
|
||||
@@ -992,8 +986,6 @@ pub async fn handle_python_reqs(
|
||||
)
|
||||
.await;
|
||||
tracing::info!(
|
||||
worker_name = %worker_name,
|
||||
job_id = %job_id,
|
||||
workspace_id = %w_id,
|
||||
is_ok = child.is_ok(),
|
||||
"finished setting up python dependencies {}",
|
||||
|
||||
Reference in New Issue
Block a user