From b22fc2d0f8de010cf061c38d322575631479fd6d Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@rubenfiszel.com>
Date: Wed, 28 Sep 2022 19:52:25 +0200
Subject: [PATCH] fix: change string default input behavior for input arg

---
 frontend/src/lib/components/ArgInput.svelte | 29 ++++++++++-----------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/frontend/src/lib/components/ArgInput.svelte b/frontend/src/lib/components/ArgInput.svelte
index c0c2521a1c..542bad3ac4 100644
--- a/frontend/src/lib/components/ArgInput.svelte
+++ b/frontend/src/lib/components/ArgInput.svelte
@@ -108,7 +108,7 @@
 	}
 
 	function validateInput(pattern: string | undefined, v: any): void {
-		if (required && (v == undefined || v == null)) {
+		if (required && (v == undefined || v == null || v === '')) {
 			error = 'This field is required'
 			valid = false
 		} else {
@@ -132,8 +132,11 @@
 	}
 
 	$: {
-		if (value == undefined) {
+		if (value == undefined || value == null) {
 			value = defaultValue
+			if ((defaultValue === undefined || defaultValue === null) && inputCat === 'string') {
+				value = ''
+			}
 		}
 	}
 
@@ -181,21 +184,14 @@
 					</div>
 				{/if}
 			</div>
-			<span class="text-2xs">Preview:</span>
+			<span class="text-2xs">Input preview:</span>
 		{/if}
 
-		<div class="grid grid-cols-2">
-			{#if description || error}
-				<div class="text-sm italic pb-1">
-					{description}
-				</div>
-				<div class="text-right text-xs {error === '' ? 'text-white' : 'font-bold text-red-600'}">
-					{error === '' ? '...' : error}
-				</div>
-			{:else}
-				<div class="mt-1" />
-			{/if}
-		</div>
+		{#if description}
+			<div class="text-sm italic pb-1">
+				{description}
+			</div>
+		{/if}
 
 		<div class="flex space-x-1">
 			{#if inputCat == 'number'}
@@ -359,5 +355,8 @@
 			{/if}
 			<slot name="actions" />
 		</div>
+		<div class="text-right text-xs {error === '' ? 'text-white' : 'font-bold text-red-600'}">
+			{error === '' ? '...' : error}
+		</div>
 	</div>
 </div>