From 9d2785beceecbbcb87dfd9486e5d42b3705a0ea2 Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Fri, 30 Jan 2026 08:17:58 +0000
Subject: [PATCH] fix npm check

---
 backend/windmill-api/openapi.yaml             | 15 +++-----
 frontend/src/lib/components/Star.svelte       | 27 ++++++++------
 .../lib/components/common/table/AppRow.svelte |  5 ++-
 .../components/common/table/FlowRow.svelte    |  5 ++-
 .../components/common/table/RawAppRow.svelte  |  5 ++-
 .../lib/components/common/table/Row.svelte    | 37 +++++++------------
 .../components/common/table/ScriptRow.svelte  |  5 ++-
 .../(logged)/flows/get/[...path]/+page.svelte |  4 +-
 .../scripts/get/[...hash]/+page.svelte        |  7 ++--
 9 files changed, 58 insertions(+), 52 deletions(-)

diff --git a/backend/windmill-api/openapi.yaml b/backend/windmill-api/openapi.yaml
index 9a1f0ecb32..09c50c31bf 100644
--- a/backend/windmill-api/openapi.yaml
+++ b/backend/windmill-api/openapi.yaml
@@ -18121,7 +18121,6 @@ components:
         - visible_to_owner
         - tag
 
-
     ExportableCompletedJob:
       type: object
       description: Completed job with full data for export/import operations
@@ -22276,7 +22275,8 @@ components:
       properties:
         kind:
           type: string
-          enum: ["script", "flow", "app", "resource", "variable"]
+          enum:
+            ["script", "flow", "app", "resource", "variable", "resource_type"]
           description: Type of the item
         path:
           type: string
@@ -22588,14 +22588,13 @@ components:
       type: object
       properties:
         service_name:
-          $ref: '#/components/schemas/NativeServiceName'
+          $ref: "#/components/schemas/NativeServiceName"
         oauth_data:
           nullable: true
-          $ref: '#/components/schemas/WorkspaceOAuthConfig'
+          $ref: "#/components/schemas/WorkspaceOAuthConfig"
       required:
         - service_name
 
-
     WorkspaceOAuthConfig:
       type: object
       properties:
@@ -22626,7 +22625,7 @@ components:
           type: string
           enum: [webhook]
         request_type:
-          $ref: '#/components/schemas/WebhookRequestType'
+          $ref: "#/components/schemas/WebhookRequestType"
       required:
         - type
         - request_type
@@ -22642,12 +22641,10 @@ components:
       type: object
       properties:
         redirect_uri:
-          type:
-            string
+          type: string
       required:
         - redirect_uri
 
-
     NativeTriggerData:
       type: object
       description: Data for creating or updating a native trigger
diff --git a/frontend/src/lib/components/Star.svelte b/frontend/src/lib/components/Star.svelte
index b4ac4c61ab..04a67bb388 100644
--- a/frontend/src/lib/components/Star.svelte
+++ b/frontend/src/lib/components/Star.svelte
@@ -1,16 +1,22 @@
 <script lang="ts">
+	import { preventDefault } from 'svelte/legacy'
+
 	import { FavoriteService } from '$lib/gen'
 	import { starStore } from '$lib/stores'
 	import { sendUserToast } from '$lib/toast'
-	import { createEventDispatcher } from 'svelte'
 	import { Star, StarOff } from 'lucide-svelte'
 
-	export let path: string
-	export let kind: 'flow' | 'app' | 'script' | 'raw_app'
-	export let starred = false
-	export let workspace_id: string
+	interface Props {
+		path: string
+		kind: 'flow' | 'app' | 'script' | 'raw_app'
+		starred?: boolean
+		workspace_id: string
+		onStarred?: (starred: boolean) => void
+	}
 
-	let buttonHover = false
+	let { path, kind, starred = false, workspace_id, onStarred }: Props = $props()
+
+	let buttonHover = $state(false)
 
 	async function onClick() {
 		buttonHover = false
@@ -29,15 +35,14 @@
 			sendUserToast('Marked as favorite, it will appear first')
 			$starStore = $starStore + 1
 		}
-		dispatch('starred', !starred)
+		onStarred?.(!starred)
 	}
-	const dispatch = createEventDispatcher()
 </script>
 
 <button
-	on:click|preventDefault={onClick}
-	on:mouseenter={() => (buttonHover = true)}
-	on:mouseleave={() => (buttonHover = false)}
+	onclick={preventDefault(onClick)}
+	onmouseenter={() => (buttonHover = true)}
+	onmouseleave={() => (buttonHover = false)}
 	class="p-2"
 >
 	{#if starred}
diff --git a/frontend/src/lib/components/common/table/AppRow.svelte b/frontend/src/lib/components/common/table/AppRow.svelte
index 08822ad433..189abc49b5 100644
--- a/frontend/src/lib/components/common/table/AppRow.svelte
+++ b/frontend/src/lib/components/common/table/AppRow.svelte
@@ -82,7 +82,10 @@
 	summary={app.summary}
 	workspaceId={app.workspace_id ?? $workspaceStore ?? ''}
 	{starred}
-	on:change
+	onStarred={(newStarred) => {
+		starred = newStarred
+		dispatch('change')
+	}}
 	canFavorite={!app.draft_only}
 	{depth}
 >
diff --git a/frontend/src/lib/components/common/table/FlowRow.svelte b/frontend/src/lib/components/common/table/FlowRow.svelte
index 4ed3429618..1abc5ae3ac 100644
--- a/frontend/src/lib/components/common/table/FlowRow.svelte
+++ b/frontend/src/lib/components/common/table/FlowRow.svelte
@@ -108,7 +108,10 @@
 	summary={flow.summary}
 	{starred}
 	{errorHandlerMuted}
-	on:change
+	onStarred={(newStarred) => {
+		starred = newStarred
+		dispatch('change')
+	}}
 	canFavorite={!flow.draft_only}
 	{depth}
 >
diff --git a/frontend/src/lib/components/common/table/RawAppRow.svelte b/frontend/src/lib/components/common/table/RawAppRow.svelte
index 10bd600080..791d27e24e 100644
--- a/frontend/src/lib/components/common/table/RawAppRow.svelte
+++ b/frontend/src/lib/components/common/table/RawAppRow.svelte
@@ -76,7 +76,10 @@
 	summary={app.summary}
 	workspaceId={app.workspace_id ?? $workspaceStore ?? ''}
 	{starred}
-	on:change
+	onStarred={(newStarred) => {
+		starred = newStarred
+		dispatch('change')
+	}}
 	canFavorite={true}
 	{depth}
 >
diff --git a/frontend/src/lib/components/common/table/Row.svelte b/frontend/src/lib/components/common/table/Row.svelte
index 0ac3531bd3..acc7505a44 100644
--- a/frontend/src/lib/components/common/table/Row.svelte
+++ b/frontend/src/lib/components/common/table/Row.svelte
@@ -1,14 +1,11 @@
 <script lang="ts">
 	import Star from '$lib/components/Star.svelte'
-	import { createEventDispatcher } from 'svelte'
 	import RowIcon from './RowIcon.svelte'
 	import { BellOff } from 'lucide-svelte'
 	import { twMerge } from 'tailwind-merge'
 	import { goto } from '$lib/navigation'
 	import { triggerableByAI } from '$lib/actions/triggerableByAI.svelte'
 
-	const dispatch = createEventDispatcher()
-
 	interface Props {
 		marked: string | undefined
 		starred: boolean
@@ -20,7 +17,7 @@
 		errorHandlerMuted?: boolean
 		aiId?: string | undefined
 		aiDescription?: string | undefined
-		kind?: 'script' | 'flow' | 'app' | 'raw_app' | 'resource' | 'variable'
+		kind?: 'script' | 'flow' | 'app' | 'raw_app' | 'resource' | 'variable' | 'resource_type'
 		summary?: string | undefined
 		path: string
 		href?: string
@@ -34,6 +31,7 @@
 				currentTarget: EventTarget & HTMLInputElement
 			}
 		) => void
+		onStarred?: (starred: boolean) => void
 	}
 
 	let {
@@ -56,7 +54,8 @@
 		badges,
 		actions,
 		customSummary,
-		onSelect = () => {}
+		onSelect = () => {},
+		onStarred = (newStarred: boolean) => {}
 	}: Props = $props()
 
 	let displayPath: string = (depth === 0 ? path : path?.split('/')?.slice(-1)?.[0]) ?? ''
@@ -80,7 +79,6 @@
 		depth > 0 ? '!rounded-none' : '',
 		disabled ? 'opacity-25' : 'hover:bg-surface-hover',
 		selected ? 'bg-surface-accent-selected' : ''
-
 	)}
 	style={depth > 0 ? `padding-left: ${depth * 32}px;` : ''}
 >
@@ -91,11 +89,14 @@
 	{/if}
 
 	{#if href}
-		<a {href} class="min-w-0 grow hover:underline decoration-gray-400 inline-flex items-center gap-4">
+		<a
+			{href}
+			class="min-w-0 grow hover:underline decoration-gray-400 inline-flex items-center gap-4"
+		>
 			{@render rowContent()}
 		</a>
 	{:else}
-			{@render rowContent()}
+		{@render rowContent()}
 	{/if}
 
 	{#if errorHandlerMuted}
@@ -108,17 +109,9 @@
 		</div>
 	{/if}
 
-	{#if canFavorite && kind !== 'resource' && kind !== 'variable'}
+	{#if canFavorite && kind !== 'resource' && kind !== 'variable' && kind !== 'resource_type'}
 		<div class="center-center h-full text-xs font-semibold text-secondary w-9">
-			<Star
-				{kind}
-				{path}
-				{starred}
-				workspace_id={workspaceId}
-				on:starred={() => {
-					dispatch('change')
-				}}
-			/>
+			<Star {kind} {path} {starred} workspace_id={workspaceId} {onStarred} />
 		</div>
 	{:else}
 		<div class="w-9"></div>
@@ -137,12 +130,10 @@
 		<div class="text-emphasis flex-wrap text-left text-xs font-semibold">
 			{#if customSummary}
 				{@render customSummary?.()}
+			{:else if marked}
+				{@html marked}
 			{:else}
-				{#if marked}
-					{@html marked}
-				{:else}
-					{!summary || summary.length == 0 ? displayPath : summary}
-				{/if}
+				{!summary || summary.length == 0 ? displayPath : summary}
 			{/if}
 		</div>
 		<div class="text-hint text-3xs truncate text-left font-normal">
diff --git a/frontend/src/lib/components/common/table/ScriptRow.svelte b/frontend/src/lib/components/common/table/ScriptRow.svelte
index 1fa78d86cd..7b5cc43d30 100644
--- a/frontend/src/lib/components/common/table/ScriptRow.svelte
+++ b/frontend/src/lib/components/common/table/ScriptRow.svelte
@@ -122,7 +122,10 @@
 	{starred}
 	{errorHandlerMuted}
 	workspaceId={$workspaceStore ?? ''}
-	on:change
+	onStarred={(newStarred) => {
+		starred = newStarred
+		dispatch('change')
+	}}
 	canFavorite={!script.draft_only}
 	{depth}
 >
diff --git a/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte b/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte
index 35c440a008..bb9ed9e954 100644
--- a/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte
+++ b/frontend/src/routes/(root)/(logged)/flows/get/[...path]/+page.svelte
@@ -517,8 +517,8 @@
 					path={flow.path}
 					{starred}
 					workspace_id={$workspaceStore}
-					on:starred={() => {
-						starred = !starred
+					onStarred={(newStarred) => {
+						starred = newStarred
 					}}
 				/>
 			{/if}
diff --git a/frontend/src/routes/(root)/(logged)/scripts/get/[...hash]/+page.svelte b/frontend/src/routes/(root)/(logged)/scripts/get/[...hash]/+page.svelte
index 5695a0270a..b89448aab0 100644
--- a/frontend/src/routes/(root)/(logged)/scripts/get/[...hash]/+page.svelte
+++ b/frontend/src/routes/(root)/(logged)/scripts/get/[...hash]/+page.svelte
@@ -656,8 +656,8 @@
 						path={script.path}
 						{starred}
 						workspace_id={$workspaceStore}
-						on:starred={() => {
-							starred = !starred
+						onStarred={(newStarred) => {
+							starred = newStarred
 						}}
 					/>
 				{/if}
@@ -815,7 +815,8 @@
 					<div class="pt-4 flex flex-row gap-1 w-full justify-end items-center">
 						{#if !isHubScript}
 							<span class="text-2xs text-secondary">
-								Edited <TimeAgo date={script.created_at || ''} /> by {script.created_by || 'unknown'}
+								Edited <TimeAgo date={script.created_at || ''} /> by {script.created_by ||
+									'unknown'}
 							</span>
 						{/if}
 						<div class="flex flex-row gap-x-2 flex-wrap items-center">