From 911fcf2012274971a93bfb32419b89348faeb7cf Mon Sep 17 00:00:00 2001
From: Ruben Fiszel <ruben@windmill.dev>
Date: Fri, 21 Feb 2025 18:09:25 +0100
Subject: [PATCH] improve error message to run executable

---
 backend/windmill-worker/src/common.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/backend/windmill-worker/src/common.rs b/backend/windmill-worker/src/common.rs
index 9fb270f269..0ffdabb857 100644
--- a/backend/windmill-worker/src/common.rs
+++ b/backend/windmill-worker/src/common.rs
@@ -936,18 +936,18 @@ pub async fn save_in_cache(
 
 fn tentatively_improve_error(err: Error, executable: &str) -> Error {
     #[cfg(unix)]
-    let err_msg = "No such file or directory (os error 2)";
+    let err_msgs = vec!["os error 2", "os error 3", "No such file or directory"];
 
     #[cfg(windows)]
-    let err_msg = "program not found";
+    let err_msgs = vec!["program not found", "os error 2", "os error 3"];
 
-    if err.to_string().contains(&err_msg) {
+    if err_msgs.iter().any(|msg| err.to_string().contains(msg)) {
         return Error::internal_err(format!(
             "Executable {executable} not found on worker. PATH: {}",
             *PATH_ENV
         ));
     }
-    return err;
+    return Error::ExecutionErr(format!("Error executing {executable}: {err:#}"));
 }
 
 pub async fn clean_cache() -> error::Result<()> {