From 5480148fe336f5bde48b41817833c8f55a52b67a Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Wed, 13 Aug 2025 00:57:15 +0000 Subject: [PATCH] migrate to state --- .../(logged)/apps/edit/[...path]/+page.svelte | 16 +-- .../(logged)/apps/get/[...path]/+page.svelte | 19 ++-- .../get_raw/[version]/[...path]/+page.svelte | 5 +- .../apps_raw/edit/[...path]/+page.svelte | 14 +-- .../apps_raw/get/[...path]/+page.svelte | 18 +-- .../deploy/[kind]/[...path]/+page.svelte | 9 +- .../flows/edit/[...path]/+page.svelte | 22 ++-- .../(logged)/flows/get/[...path]/+page.svelte | 6 +- .../oauth/callback/[client_name]/+page.svelte | 14 +-- .../(root)/(logged)/run/[...run]/+page.svelte | 13 +-- .../(logged)/runs/[...path]/+page.svelte | 104 +++++++++--------- .../scripts/edit/[...path]/+page.svelte | 16 +-- .../scripts/get/[...hash]/+page.svelte | 10 +- frontend/src/routes/a/[...path]/+page.svelte | 12 +- .../[job]/[resume]/[hmac]/+page.svelte | 44 ++++---- .../[workspace]/[...secret]/+page.svelte | 16 +-- .../src/routes/scripts/p/[...path].svelte | 8 +- .../login_callback/[client_name]/+page.svelte | 10 +- 18 files changed, 178 insertions(+), 178 deletions(-) diff --git a/frontend/src/routes/(root)/(logged)/apps/edit/[...path]/+page.svelte b/frontend/src/routes/(root)/(logged)/apps/edit/[...path]/+page.svelte index 86dcede1fa..2b642e62ab 100644 --- a/frontend/src/routes/(root)/(logged)/apps/edit/[...path]/+page.svelte +++ b/frontend/src/routes/(root)/(logged)/apps/edit/[...path]/+page.svelte @@ -7,7 +7,6 @@ DraftService } from '$lib/gen' import { workspaceStore } from '$lib/stores' - import { page } from '$app/stores' import { cleanValueProperties, decodeState, type Value } from '$lib/utils' import { afterNavigate, replaceState } from '$app/navigation' import { goto } from '$lib/navigation' @@ -17,6 +16,7 @@ import UnsavedConfirmationModal from '$lib/components/common/confirmationModal/UnsavedConfirmationModal.svelte' import { stateSnapshot } from '$lib/svelte5Utils.svelte' import { untrack } from 'svelte' + import { page } from '$app/state' let app = $state( undefined as (AppWithLastVersion & { draft_only?: boolean; value: any }) | undefined @@ -33,18 +33,18 @@ } | undefined = $state(undefined) let redraw = $state(0) - let path = $page.params.path + let path = page.params.path ?? '' - let nodraft = $page.url.searchParams.get('nodraft') + let nodraft = page.url.searchParams.get('nodraft') afterNavigate(() => { if (nodraft) { - let url = new URL($page.url.href) + let url = new URL(page.url.href) url.search = '' - replaceState(url.toString(), $page.state) + replaceState(url.toString(), page.state) } }) - const initialState = nodraft ? undefined : localStorage.getItem(`app-${$page.params.path}`) + const initialState = nodraft ? undefined : localStorage.getItem(`app-${page.params.path}`) let stateLoadedFromLocalStorage = initialState != undefined ? decodeState(initialState) : undefined @@ -229,13 +229,13 @@ summary={app.summary} app={app.value} newPath={app.path} - path={$page.params.path} + path={page.params.path ?? ''} policy={app.policy} bind:savedApp {diffDrawer} version={app.versions ? app.versions[app.versions.length - 1] : undefined} newApp={false} - replaceStateFn={(path) => replaceState(path, $page.state)} + replaceStateFn={(path) => replaceState(path, page.state)} gotoFn={(path, opt) => goto(path, opt)} > {#snippet unsavedConfirmationModal({ diff --git a/frontend/src/routes/(root)/(logged)/apps/get/[...path]/+page.svelte b/frontend/src/routes/(root)/(logged)/apps/get/[...path]/+page.svelte index 8a51bcc3d0..ea50471b82 100644 --- a/frontend/src/routes/(root)/(logged)/apps/get/[...path]/+page.svelte +++ b/frontend/src/routes/(root)/(logged)/apps/get/[...path]/+page.svelte @@ -1,6 +1,5 @@ {#if app} @@ -54,13 +53,13 @@ name: $userStore?.name, username: $userStore?.username, groups: $userStore?.groups, - query: Object.fromEntries($page.url.searchParams.entries()), - hash: $page.url.hash.substring(1) + query: Object.fromEntries(page.url.searchParams.entries()), + hash: page.url.hash.substring(1) }} workspace={$workspaceStore ?? ''} summary={app.summary} app={app.value} - appPath={$page.params.path} + appPath={page.params.path} {breakpoint} policy={app.policy} isEditor={false} diff --git a/frontend/src/routes/(root)/(logged)/apps/get_raw/[version]/[...path]/+page.svelte b/frontend/src/routes/(root)/(logged)/apps/get_raw/[version]/[...path]/+page.svelte index cd4bdecd44..8d8d66ef9a 100644 --- a/frontend/src/routes/(root)/(logged)/apps/get_raw/[version]/[...path]/+page.svelte +++ b/frontend/src/routes/(root)/(logged)/apps/get_raw/[version]/[...path]/+page.svelte @@ -1,10 +1,9 @@ -

Deploy {$page.params.kind} {$page.params.path}

- +

Deploy {page.params.kind} {page.params.path}

+
diff --git a/frontend/src/routes/(root)/(logged)/flows/edit/[...path]/+page.svelte b/frontend/src/routes/(root)/(logged)/flows/edit/[...path]/+page.svelte index 80cb8f3002..a86d10b1db 100644 --- a/frontend/src/routes/(root)/(logged)/flows/edit/[...path]/+page.svelte +++ b/frontend/src/routes/(root)/(logged)/flows/edit/[...path]/+page.svelte @@ -1,7 +1,6 @@