From 486b9f6f2184f1db320c2b8922a0010cf4d5ebc2 Mon Sep 17 00:00:00 2001 From: Diego Imbert <70353967+diegoimbert@users.noreply.github.com> Date: Thu, 19 Feb 2026 14:42:16 +0100 Subject: [PATCH] Fix empty assets array showing up in diff (#8017) --- backend/windmill-types/src/assets.rs | 1 + frontend/src/lib/components/ScriptBuilder.svelte | 15 ++++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/backend/windmill-types/src/assets.rs b/backend/windmill-types/src/assets.rs index 5f75388410..cf86d83801 100644 --- a/backend/windmill-types/src/assets.rs +++ b/backend/windmill-types/src/assets.rs @@ -40,6 +40,7 @@ pub struct AssetWithAltAccessType { pub path: String, pub kind: AssetKind, pub access_type: Option, + #[serde(skip_serializing_if = "Option::is_none")] pub alt_access_type: Option, /// Map of column name to access type for column-level access tracking #[serde(skip_serializing_if = "Option::is_none")] diff --git a/frontend/src/lib/components/ScriptBuilder.svelte b/frontend/src/lib/components/ScriptBuilder.svelte index ca3c47ef20..7e57ae0660 100644 --- a/frontend/src/lib/components/ScriptBuilder.svelte +++ b/frontend/src/lib/components/ScriptBuilder.svelte @@ -773,15 +773,16 @@ triggersState.getDraftTriggersSnapshot() ) + const deployed = deployedValue ?? savedScript + const current = { ...script, draft_triggers: currentDraftTriggers } + if (current.assets && !current.assets.length) delete current.assets + diffDrawer?.openDrawer() diffDrawer?.setDiff({ mode: 'normal', - deployed: deployedValue ?? savedScript, + deployed, draft: savedScript['draft'], - current: { - ...script, - draft_triggers: currentDraftTriggers - } + current }) } } @@ -1443,8 +1444,8 @@ {#if script.dedicated_worker}
- A worker group needs to be configured to listen to this script. Select - it in the dedicated workers section of the worker group configuration. + A worker group needs to be configured to listen to this script. Select it + in the dedicated workers section of the worker group configuration.
{/if}