diff --git a/backend/windmill-api/src/settings.rs b/backend/windmill-api/src/settings.rs index 90c3748cce..6d0cb5df6c 100644 --- a/backend/windmill-api/src/settings.rs +++ b/backend/windmill-api/src/settings.rs @@ -56,7 +56,8 @@ pub async fn test_email( require_super_admin(&db, &authed.email).await?; let smtp = test_email.smtp; let to = test_email.to; - let client = SmtpClientBuilder::new(smtp.host, smtp.port).implicit_tls(smtp.tls_implicit); + let client = SmtpClientBuilder::new(smtp.host, smtp.port) + .implicit_tls(smtp.tls_implicit.unwrap_or(false)); let client = if let (Some(username), Some(password)) = (smtp.username, smtp.password) { if !username.is_empty() { client.credentials((username, password)) diff --git a/backend/windmill-api/src/users.rs b/backend/windmill-api/src/users.rs index 227e854b83..aee33eb852 100644 --- a/backend/windmill-api/src/users.rs +++ b/backend/windmill-api/src/users.rs @@ -1666,7 +1666,8 @@ pub fn send_email_if_possible(subject: &str, content: &str, to: &str) { pub async fn send_email_if_possible_intern(subject: &str, content: &str, to: &str) -> Result<()> { if let Some(smtp) = SERVER_CONFIG.read().await.smtp.clone() { - let client = SmtpClientBuilder::new(smtp.host, smtp.port).implicit_tls(smtp.tls_implicit); + let client = SmtpClientBuilder::new(smtp.host, smtp.port) + .implicit_tls(smtp.tls_implicit.unwrap_or(false)); let client = if let (Some(username), Some(password)) = (smtp.username, smtp.password) { if !username.is_empty() { client.credentials((username, password)) diff --git a/backend/windmill-common/src/server.rs b/backend/windmill-common/src/server.rs index a6b12ca7b6..f18d3f873c 100644 --- a/backend/windmill-common/src/server.rs +++ b/backend/windmill-common/src/server.rs @@ -9,7 +9,7 @@ pub struct Smtp { pub password: Option, pub port: u16, pub from: String, - pub tls_implicit: bool, + pub tls_implicit: Option, } #[derive(Serialize, Deserialize, PartialEq)] @@ -40,7 +40,7 @@ pub async fn load_server_config(db: &DB) -> error::Result { host, username, password, - tls_implicit: config.smtp_tls_implicit.unwrap_or(false), + tls_implicit: config.smtp_tls_implicit, port: config.smtp_port.unwrap_or(587), from: config .smtp_from @@ -61,8 +61,7 @@ pub async fn load_server_config(db: &DB) -> error::Result { password, tls_implicit: std::env::var("SMTP_TLS_IMPLICIT") .ok() - .and_then(|p| p.parse().ok()) - .unwrap_or(false), + .and_then(|p| p.parse().ok()), port: std::env::var("SMTP_PORT") .ok() .and_then(|p| p.parse().ok()) diff --git a/frontend/src/lib/components/InstanceGroupEditor.svelte b/frontend/src/lib/components/InstanceGroupEditor.svelte index 7507311824..6bc0211991 100644 --- a/frontend/src/lib/components/InstanceGroupEditor.svelte +++ b/frontend/src/lib/components/InstanceGroupEditor.svelte @@ -1,7 +1,5 @@