From 32b2d18eccfeef1a54230a60fd2bf9ebcc2b1d62 Mon Sep 17 00:00:00 2001 From: Ruben Fiszel Date: Sun, 18 Sep 2022 10:01:43 +0200 Subject: [PATCH] fix schema required added multiple times --- frontend/src/lib/components/SchemaEditor.svelte | 4 +++- frontend/src/lib/infer.ts | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/frontend/src/lib/components/SchemaEditor.svelte b/frontend/src/lib/components/SchemaEditor.svelte index 0924fb7261..2492b74740 100644 --- a/frontend/src/lib/components/SchemaEditor.svelte +++ b/frontend/src/lib/components/SchemaEditor.svelte @@ -65,7 +65,9 @@ } else { schema.properties[modalProperty.name] = modalToSchema(modalProperty) if (modalProperty.required) { - schema.required = [...schema.required, modalProperty.name] + if (!schema.required.includes(modalProperty.name)) { + schema.required.push(modalProperty.name) + } } else if (schema.required.includes(modalProperty.name)) { const index = schema.required.indexOf(modalProperty.name, 0) if (index > -1) { diff --git a/frontend/src/lib/infer.ts b/frontend/src/lib/infer.ts index e21e7ec5ac..1d9669e166 100644 --- a/frontend/src/lib/infer.ts +++ b/frontend/src/lib/infer.ts @@ -37,7 +37,7 @@ export async function inferArgs( argSigToJsonSchemaType(arg.typ, schema.properties[arg.name]) schema.properties[arg.name].default = arg.default - if (!arg.has_default) { + if (!arg.has_default && !schema.required.includes(arg.name)) { schema.required.push(arg.name) } }