kalugin66/windmill
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: simplify codex PR review comments

Browse Source
This commit is contained in:
centdix
2026-03-30 21:13:47 +02:00
parent dd3cc60d80
commit 2455c58a25
3 changed files with 13 additions and 233 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
.github/codex/pr-review.prompt.md vendored
View File

@@ -14,14 +14,10 @@ Repository context:
- Do not modify any files.
Output requirements:
- Return JSON that matches the provided schema exactly.
- `summary` must be a short overall review summary.
- `reproduction_instructions` must be a short descriptive paragraph for a tester explaining how to navigate the app to observe the change. Do not make it a numbered list. If the diff is not enough to infer this safely, say that plainly.
- `findings` must contain only high-signal issues. Use an empty array if there are no such issues.
Finding requirements:
- Use a changed file path from this PR.
- Set `line` to the exact right-side line number on the PR head when you are confident it is part of the diff.
- If you cannot map a finding to a changed line with confidence, leave `line` as `null`.
- Keep each finding concise and specific.
- Return a GitHub PR comment in markdown, not JSON.
- Start with `## Codex Review`.
- Give a short overall summary first.
- If you found high-signal issues, list them in a short numbered list with file paths and line numbers when you know them confidently.
- If you found no high-signal issues, say that explicitly.
- End with a `### Reproduction instructions` section containing a short descriptive paragraph for a tester explaining how to navigate the app to observe the change. Do not make it a numbered list. If the diff is not enough to infer this safely, say that plainly.
- Prefer at most 10 findings.

74
.github/codex/review-output.schema.json vendored
View File

@@ -1,74 +0,0 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"title": "CodexPullRequestReview",
"type": "object",
"additionalProperties": false,
"required": [
"summary",
"reproduction_instructions",
"findings"
],
"properties": {
"summary": {
"type": "string",
"maxLength": 4000
},
"reproduction_instructions": {
"type": "string",
"maxLength": 4000
},
"findings": {
"type": "array",
"maxItems": 10,
"items": {
"type": "object",
"additionalProperties": false,
"required": [
"title",
"body",
"path",
"line",
"severity",
"reason"
],
"properties": {
"title": {
"type": "string",
"maxLength": 200
},
"body": {
"type": "string",
"maxLength": 2000
},
"path": {
"type": "string",
"maxLength": 500
},
"line": {
"type": [
"integer",
"null"
],
"minimum": 1
},
"severity": {
"type": "string",
"enum": [
"high",
"medium",
"low"
]
},
"reason": {
"type": "string",
"enum": [
"bug",
"security",
"claude_md"
]
}
}
}
}
}
}