One more bit of cleanup for PR #529.
We can register `handleClick` once on the `<tr>` tag and just have the
onclick handler on `col-select` too. Because dispatcher calls
`event.stopPropagation()` we don't need to worry about event bubbling
up to the `<tr>`.
This means people who add a lot of torrents will always have their latest torrents at the top when they open the app, instead of having to scroll all the way down
The goal of this commit is to merge the two torrent status lines onto a
single, concise line which has high signal and information density.
- Hide download speed, upload speed, and number of peers when 0,
because that's just noise.
- Remove number of files, because that information can be found by
expanding the torrent.
This also allowed the further reduction of the torrent item height from
110px to 100px.
Based on @watson's PR #463.
Differences:
- Remove the "Open Folder" link from expanded torrent view.
- Use showItemInFolder instead of openItem electron API
- Add a separator
- Use IPC to invoke electron.shell.showItemInFolder from main process
I found it awkward to listen to the video tags 'playing' and 'paused'
events, when we're controlling the state that defines what state it's
in in the first place.
This commit removes those listeners, in favor of just setting things to
the right state immediately when play(), pause(), or playPause() is
called.
Added play(), pause() methods for clarity.
* fix error about pop
* location-history: add optional callbacks
* set handler on first tick
discovered by @dcposch
* Show error when media format is unsupported
Before this change, the player would just get stuck on the loading
screen forever without notifying the user.
* issue template
* cleanup closePlayer() and stopServer()
* Add subtitle support (via drag-n-drop)
Drag and drop a subtitles file (.srt or .vtt) onto the player (or the
app icon on OS X) to add subtitles to the currently playing video.
For #281
* add multiple subtitles structure
* add open subtitle dialog from cc player controls
