kalugin66/webtorrent-desktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use correct icon name

Browse Source 
https://github.com/feross/webtorrent-desktop/issues/467

The icon name is "closed_caption", not "closed_captions"
http://jsbin.com/fenejob/1/edit?html,output

The extra space we're seeing is the icon font rendering the 's', which
renders as nothing.
This commit is contained in:
Feross Aboukhadijeh
2016-05-31 17:12:09 -07:00
parent c82bdbd39d
commit f9d4e5e077
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
renderer/main.css
View File

@@ -715,10 +715,7 @@ body.drag .app::after {
font-size: 22px; font-size: 22px;
opacity: 0.85; opacity: 0.85;
/* /* Make all icons have uniform spacing */
* Fix for overflowing captions icon
* https://github.com/feross/webtorrent-desktop/issues/467
*/
max-width: 23px; max-width: 23px;
overflow: hidden; overflow: hidden;
} }
@@ -754,7 +751,7 @@ body.drag .app::after {
opacity: 0.8; opacity: 0.8;
} }
.player .controls .icon.closed-captions { .player .controls .icon.closed-caption {
font-size: 26px; font-size: 26px;
margin-top: 6px; margin-top: 6px;
} }
@@ -822,7 +819,7 @@ body.drag .app::after {
transition-timing-function: ease-out; transition-timing-function: ease-out;
} }
.player .controls .closed-captions.active, .player .controls .closed-caption.active,
.player .controls .device.active { .player .controls .device.active {
color: #9af; color: #9af;
} }

4
renderer/views/player.js
View File

@@ -363,10 +363,10 @@ function renderPlayerControls (state) {
if (state.playing.type === 'video') { if (state.playing.type === 'video') {
// show closed captions icon // show closed captions icon
elements.push(hx` elements.push(hx`
<i.icon.closed-captions.float-right <i.icon.closed-caption.float-right
class=${captionsClass} class=${captionsClass}
onclick=${handleSubtitles}> onclick=${handleSubtitles}>
closed_captions closed_caption
</i> </i>
`) `)
} }