From f2c531baa4c20a531b5133f564e7be3f6c8f9e50 Mon Sep 17 00:00:00 2001
From: hicom150 <hicom150@gmail.com>
Date: Sat, 12 Oct 2019 17:44:13 +0200
Subject: [PATCH] use videoTracks and audioTracks to check unsupported codecs

---
 src/main/windows/about.js         |  3 ++-
 src/main/windows/main.js          |  3 ++-
 src/main/windows/webtorrent.js    |  3 ++-
 src/renderer/pages/player-page.js | 45 +++++++++++++++++++++----------
 4 files changed, 37 insertions(+), 17 deletions(-)

diff --git a/src/main/windows/about.js b/src/main/windows/about.js
index fc16d517..1e6d6dc5 100644
--- a/src/main/windows/about.js
+++ b/src/main/windows/about.js
@@ -25,7 +25,8 @@ function init () {
     title: 'About ' + config.APP_WINDOW_TITLE,
     useContentSize: true,
     webPreferences: {
-      nodeIntegration: true
+      nodeIntegration: true,
+      enableBlinkFeatures: 'AudioVideoTracks'
     },
     width: 300
   })
diff --git a/src/main/windows/main.js b/src/main/windows/main.js
index dbfb7d0c..11aad3d0 100644
--- a/src/main/windows/main.js
+++ b/src/main/windows/main.js
@@ -44,7 +44,8 @@ function init (state, options) {
     useContentSize: true, // Specify web page size without OS chrome
     width: initialBounds.width,
     webPreferences: {
-      nodeIntegration: true
+      nodeIntegration: true,
+      enableBlinkFeatures: 'AudioVideoTracks'
     },
     x: initialBounds.x,
     y: initialBounds.y
diff --git a/src/main/windows/webtorrent.js b/src/main/windows/webtorrent.js
index 8c58043b..cd08e225 100644
--- a/src/main/windows/webtorrent.js
+++ b/src/main/windows/webtorrent.js
@@ -26,7 +26,8 @@ function init () {
     title: 'webtorrent-hidden-window',
     useContentSize: true,
     webPreferences: {
-      nodeIntegration: true
+      nodeIntegration: true,
+      enableBlinkFeatures: 'AudioVideoTracks'
     },
     width: 150
   })
diff --git a/src/renderer/pages/player-page.js b/src/renderer/pages/player-page.js
index a087b3b9..b9998d13 100644
--- a/src/renderer/pages/player-page.js
+++ b/src/renderer/pages/player-page.js
@@ -54,13 +54,6 @@ function renderMedia (state) {
       mediaElement.pause()
     } else if (!state.playing.isPaused && mediaElement.paused) {
       mediaElement.play()
-        .then(
-          () => dispatch('mediaSuccess'),
-          (err) => {
-            console.error(`Error playing mediaElement: ${err.name}`)
-            dispatch('mediaError', 'Codec unsupported')
-          }
-        )
     }
     // When the user clicks or drags on the progress bar, jump to that position
     if (state.playing.jumpToTime != null) {
@@ -132,6 +125,7 @@ function renderMedia (state) {
       onLoadedMetadata={onLoadedMetadata}
       onEnded={onEnded}
       onStalled={dispatcher('mediaStalled')}
+      onError={dispatcher('mediaError')}
       onTimeUpdate={dispatcher('mediaTimeUpdate')}
       onEncrypted={dispatcher('mediaEncrypted')}
     >
@@ -151,15 +145,38 @@ function renderMedia (state) {
     </div>
   )
 
-  // As soon as we know the video dimensions, resize the window
   function onLoadedMetadata (e) {
-    if (state.playing.type !== 'video') return
-    const video = e.target
-    const dimensions = {
-      width: video.videoWidth,
-      height: video.videoHeight
+    const mediaElement = e.target
+
+    // check if we can decode video and audio track
+    if (state.playing.type === 'video') {
+      if (mediaElement.videoTracks.length === 0) {
+        dispatch('mediaError', 'Video codec unsupported')
+      }
+
+      if (mediaElement.audioTracks.length === 0) {
+        dispatch('mediaError', 'Audio codec unsupported')
+      }
+
+      dispatch('mediaSuccess')
+
+      const dimensions = {
+        width: mediaElement.videoWidth,
+        height: mediaElement.videoHeight
+      }
+
+      // As soon as we know the video dimensions, resize the window
+      dispatch('setDimensions', dimensions)
+    }
+
+    // check if we can decode audio track
+    if (state.playing.type === 'audio') {
+      if (mediaElement.audioTracks.length === 0) {
+        dispatch('mediaError', 'Audio codec unsupported')
+      }
+
+      dispatch('mediaSuccess')
     }
-    dispatch('setDimensions', dimensions)
   }
 
   function onEnded (e) {