From ecd877551e2d66db157a45520a4f0651ed76cb7f Mon Sep 17 00:00:00 2001 From: Feross Aboukhadijeh Date: Fri, 30 Sep 2016 15:32:19 -0700 Subject: [PATCH] sound: remove preloading Sound playing is basically instant -- I was over-engineering when I added this. --- src/renderer/lib/sound.js | 12 ------------ src/renderer/main.js | 1 - 2 files changed, 13 deletions(-) diff --git a/src/renderer/lib/sound.js b/src/renderer/lib/sound.js index 940d9c3a..1215fbfb 100644 --- a/src/renderer/lib/sound.js +++ b/src/renderer/lib/sound.js @@ -1,5 +1,4 @@ module.exports = { - preload, play } @@ -47,17 +46,6 @@ const sounds = { } } -function preload () { - for (let name in sounds) { - if (!cache[name]) { - const sound = sounds[name] - const audio = cache[name] = new window.Audio() - audio.volume = sound.volume - audio.src = sound.url - } - } -} - function play (name) { let audio = cache[name] if (!audio) { diff --git a/src/renderer/main.js b/src/renderer/main.js index e97af39d..68555f47 100644 --- a/src/renderer/main.js +++ b/src/renderer/main.js @@ -132,7 +132,6 @@ function onState (err, _state) { // Runs a few seconds after the app loads, to avoid slowing down startup time function delayedInit () { lazyLoadCast() - sound.preload() } // Lazily loads Chromecast and Airplay support