Do not use setVolume for storing global volume
This commit is contained in:
committed by
Feross Aboukhadijeh
parent
829206e921
commit
e3c6049fdb
@@ -415,8 +415,7 @@ function setVolume (volume) {
|
|||||||
if (isCasting()) {
|
if (isCasting()) {
|
||||||
Cast.setVolume(volume)
|
Cast.setVolume(volume)
|
||||||
} else {
|
} else {
|
||||||
// Persist volume across videos
|
state.playing.setVolume = volume
|
||||||
state.setVolume = volume
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -51,8 +51,9 @@ function renderMedia (state) {
|
|||||||
mediaElement.playbackRate = state.playing.playbackRate
|
mediaElement.playbackRate = state.playing.playbackRate
|
||||||
}
|
}
|
||||||
// Set volume
|
// Set volume
|
||||||
if (state.setVolume !== null && isFinite(state.setVolume)) {
|
if (state.playing.setVolume !== null && isFinite(state.playing.setVolume)) {
|
||||||
mediaElement.volume = state.setVolume
|
mediaElement.volume = state.playing.setVolume
|
||||||
|
state.playing.setVolume = null
|
||||||
}
|
}
|
||||||
|
|
||||||
// Switch to the newly added subtitle track, if available
|
// Switch to the newly added subtitle track, if available
|
||||||
|
|||||||
Reference in New Issue
Block a user