kalugin66/webtorrent-desktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix formatting of measurement units

Browse Source 
There were some incorrectly formatted unit symbols and units names in
the app, so this commit fixes them per SI and ISO/IEC specifications.
This commit is contained in:
Varun Varada
2020-12-22 18:58:43 -06:00
parent 919af5bf15
commit d299704f57
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/renderer/pages/player-page.js
View File

@@ -340,13 +340,13 @@ function renderAudioMetadata (state) {
format.push(fileSummary.audioInfo.format.codec) format.push(fileSummary.audioInfo.format.codec)
} }
if (fileSummary.audioInfo.format.bitrate) { if (fileSummary.audioInfo.format.bitrate) {
format.push(Math.round(fileSummary.audioInfo.format.bitrate / 1000) + ' kbps') // 128 kbps format.push(Math.round(fileSummary.audioInfo.format.bitrate / 1000) + ' kbit/s') // 128 kbit/s
} }
if (fileSummary.audioInfo.format.sampleRate) { if (fileSummary.audioInfo.format.sampleRate) {
format.push(Math.round(fileSummary.audioInfo.format.sampleRate / 100) / 10 + ' kHz') format.push(Math.round(fileSummary.audioInfo.format.sampleRate / 100) / 10 + ' kHz')
} }
if (fileSummary.audioInfo.format.bitsPerSample) { if (fileSummary.audioInfo.format.bitsPerSample) {
format.push(fileSummary.audioInfo.format.bitsPerSample + ' bit') format.push(fileSummary.audioInfo.format.bitsPerSample + '-bit')
} }
if (format.length > 0) { if (format.length > 0) {
elems.push(( elems.push((
@@ -450,9 +450,9 @@ function renderCastScreen (state) {
const minutes = Math.floor(rawEta / 60) % 60 const minutes = Math.floor(rawEta / 60) % 60
const seconds = Math.floor(rawEta % 60) const seconds = Math.floor(rawEta % 60)
const hoursStr = hours ? hours + 'h' : '' const hoursStr = hours ? hours + ' h' : ''
const minutesStr = (hours || minutes) ? minutes + 'm' : '' const minutesStr = (hours || minutes) ? minutes + ' min' : ''
const secondsStr = seconds + 's' const secondsStr = seconds + ' s'
return (<span>{hoursStr} {minutesStr} {secondsStr} remaining</span>) return (<span>{hoursStr} {minutesStr} {secondsStr} remaining</span>)
} }

6
src/renderer/pages/torrent-list-page.js
View File

@@ -198,9 +198,9 @@ module.exports = class TorrentList extends React.Component {
// Only display hours and minutes if they are greater than 0 but always // Only display hours and minutes if they are greater than 0 but always
// display minutes if hours is being displayed // display minutes if hours is being displayed
const hoursStr = hours ? hours + 'h' : '' const hoursStr = hours ? hours + ' h' : ''
const minutesStr = (hours || minutes) ? minutes + 'm' : '' const minutesStr = (hours || minutes) ? minutes + ' min' : ''
const secondsStr = seconds + 's' const secondsStr = seconds + ' s'
return (<span key='eta'>{hoursStr} {minutesStr} {secondsStr} remaining</span>) return (<span key='eta'>{hoursStr} {minutesStr} {secondsStr} remaining</span>)
} }