Save selected subtitle (#702)

renderer/controllers/playback-controller.js

@@ -224,6 +224,11 @@ function openPlayerFromActiveTorrent (state, torrentSummary, index, timeout, cb)
   // if it's video, check for subtitles files that are done downloading
   dispatch('checkForSubtitles')
 
+  // enable previously selected subtitle track
+  if (fileSummary.selectedSubtitle) {
+    dispatch('addSubtitles', [fileSummary.selectedSubtitle], true)
+  }
+
   ipcRenderer.send('wt-start-server', torrentSummary.infoHash, index)
   ipcRenderer.once('wt-server-' + torrentSummary.infoHash, (e, info) => {
     clearTimeout(timeout)

renderer/controllers/subtitles-controller.js

@@ -31,10 +31,11 @@ module.exports = class SubtitlesController {
   }
 
   addSubtitles (files, autoSelect) {
+    var state = this.state
     // Subtitles are only supported when playing video files
-    if (this.state.playing.type !== 'video') return
+    if (state.playing.type !== 'video') return
     if (files.length === 0) return
-    var subtitles = this.state.playing.subtitles
+    var subtitles = state.playing.subtitles
 
     // Read the files concurrently, then add all resulting subtitle tracks
     var tasks = files.map((file) => (cb) => loadSubtitle(file, cb))
@@ -44,15 +45,17 @@ module.exports = class SubtitlesController {
       for (var i = 0; i < tracks.length; i++) {
         // No dupes allowed
         var track = tracks[i]
-        if (subtitles.tracks.some(
-          (t) => track.filePath === t.filePath)) continue
+        var trackIndex = state.playing.subtitles.tracks
+          .findIndex((t) => track.filePath === t.filePath)
 
         // Add the track
-        subtitles.tracks.push(track)
+        if (trackIndex === -1) {
+          trackIndex = state.playing.subtitles.tracks.push(track) - 1
+        }
 
         // If we're auto-selecting a track, try to find one in the user's language
         if (autoSelect && (i === 0 || isSystemLanguage(track.language))) {
-          subtitles.selectedIndex = subtitles.tracks.length - 1
+          state.playing.subtitles.selectedIndex = trackIndex
         }
       }
 

renderer/main.js

@@ -199,6 +199,7 @@ const dispatchHandlers = {
   'selectSubtitle': (index) => controllers.subtitles.selectSubtitle(index),
   'toggleSubtitlesMenu': () => controllers.subtitles.toggleSubtitlesMenu(),
   'checkForSubtitles': () => controllers.subtitles.checkForSubtitles(),
+  'addSubtitles': (files, autoSelect) => controllers.subtitles.addSubtitles(files, autoSelect),
 
   // Local media: <video>, <audio>, VLC
   'mediaStalled': () => controllers.media.mediaStalled(),

renderer/views/player.js

@@ -73,6 +73,15 @@ function renderMedia (state) {
     var file = state.getPlayingFileSummary()
     file.currentTime = state.playing.currentTime = mediaElement.currentTime
     file.duration = state.playing.duration = mediaElement.duration
+
+    // Save selected subtitle
+    if (state.playing.subtitles.selectedIndex !== -1) {
+      var index = state.playing.subtitles.selectedIndex
+      file.selectedSubtitle = state.playing.subtitles.tracks[index].filePath
+    } else if (file.selectedSubtitle != null) {
+      delete file.selectedSubtitle
+    }
+
     state.playing.volume = mediaElement.volume
   }