From ab20dc42f13f263a27246b6ac91d3f95fdd8fcdd Mon Sep 17 00:00:00 2001 From: Borewit Date: Sun, 7 Oct 2018 20:15:12 +0200 Subject: [PATCH] #1426 Consistent error message if no suitable poster image could be found. --- src/renderer/lib/torrent-poster.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/renderer/lib/torrent-poster.js b/src/renderer/lib/torrent-poster.js index 1b1ed92a..b67d66f5 100644 --- a/src/renderer/lib/torrent-poster.js +++ b/src/renderer/lib/torrent-poster.js @@ -5,6 +5,8 @@ const path = require('path') const mediaExtensions = require('./media-extensions') +const msgNoSuitablePoster = 'Cannot generate a poster from any files in the torrent' + function torrentPoster (torrent, cb) { // First, try to use a poster image if available const posterFile = torrent.files.filter(function (file) { @@ -23,7 +25,7 @@ function torrentPoster (torrent, cb) { if (bestScore.size === 0) { // Admit defeat, no video, audio or image had a significant presence - return cb(new Error('Cannot generate a poster from any files in the torrent')) + return cb(new Error(msgNoSuitablePoster)) } // Based on which media type is dominant we select the corresponding poster function @@ -110,7 +112,7 @@ function scoreAudioCoverFile (imgFile) { function torrentPosterFromAudio (torrent, cb) { const imageFiles = filterOnExtension(torrent, mediaExtensions.image) - if (imageFiles.length === 0) return cb(new Error('Generated poster contains no files')) + if (imageFiles.length === 0) return cb(new Error(msgNoSuitablePoster)) const bestCover = imageFiles.map(file => { return { @@ -172,7 +174,7 @@ function torrentPosterFromVideo (torrent, cb) { server.destroy() - if (buf.length === 0) return cb(new Error('Generated poster contains no data')) + if (buf.length === 0) return cb(new Error(msgNoSuitablePoster)) cb(null, buf, '.jpg') }