From a881668b389ab2ef8c830f3ef6200270004b96d4 Mon Sep 17 00:00:00 2001 From: Ameet Kaustav Date: Tue, 29 Oct 2019 22:28:07 -0700 Subject: [PATCH 1/4] Fix: Increase height of 'About' window --- src/main/windows/about.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/windows/about.js b/src/main/windows/about.js index 1e6d6dc5..0b48c6f9 100644 --- a/src/main/windows/about.js +++ b/src/main/windows/about.js @@ -15,7 +15,7 @@ function init () { backgroundColor: '#ECECEC', center: true, fullscreen: false, - height: 170, + height: 220, icon: getIconPath(), maximizable: false, minimizable: false, From 35717e9dfb8d191718b497467fe04aa57ab52695 Mon Sep 17 00:00:00 2001 From: Mathias Rasmussen Date: Wed, 30 Oct 2019 12:58:30 +0100 Subject: [PATCH 2/4] Fix config copyright path in about window --- static/about.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/about.html b/static/about.html index f7976bdd..c177b3c7 100644 --- a/static/about.html +++ b/static/about.html @@ -34,6 +34,6 @@ () ()

-

+

From ab129fa233d149d1e16bda7632ce1695f0afcd4b Mon Sep 17 00:00:00 2001 From: Ameet Kaustav Date: Thu, 31 Oct 2019 01:17:09 -0700 Subject: [PATCH 3/4] Fix: Increase Height of 'About' window even more --- src/main/windows/about.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/windows/about.js b/src/main/windows/about.js index 0b48c6f9..335a437f 100644 --- a/src/main/windows/about.js +++ b/src/main/windows/about.js @@ -15,7 +15,7 @@ function init () { backgroundColor: '#ECECEC', center: true, fullscreen: false, - height: 220, + height: 250, icon: getIconPath(), maximizable: false, minimizable: false, From 2b8fa8b6fe57bf1c6d29b60b57ac3c862eaf2c69 Mon Sep 17 00:00:00 2001 From: Julen Garcia Leunda Date: Tue, 26 Nov 2019 16:59:10 +0100 Subject: [PATCH 4/4] fix review comments --- src/main/windows/about.js | 7 ++++--- static/about.html | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/main/windows/about.js b/src/main/windows/about.js index 335a437f..52c3a1c3 100644 --- a/src/main/windows/about.js +++ b/src/main/windows/about.js @@ -33,11 +33,12 @@ function init () { win.loadURL(config.WINDOW_ABOUT) - // No menu on the About window - win.setMenu(null) - win.once('ready-to-show', function () { win.show() + // No menu on the About window + // Hack: BrowserWindow removeMenu method not working on electron@7 + // https://github.com/electron/electron/issues/21088 + win.setMenuBarVisibility(false) }) win.once('closed', function () { diff --git a/static/about.html b/static/about.html index c177b3c7..6433ae9c 100644 --- a/static/about.html +++ b/static/about.html @@ -34,6 +34,6 @@ () ()

-

+