Merge pull request #795 from feross/small-fixes

A bunch of small fixes
This commit is contained in:
Feross Aboukhadijeh
2016-08-22 02:04:19 +02:00
committed by GitHub
5 changed files with 9 additions and 12 deletions

View File

@@ -26,7 +26,7 @@ function spawn (path, url, title) {
// Try to find and use VLC if external player is not specified
vlcCommand(function (err, vlcPath) {
if (err) return windows.main.dispatch('externalPlayerNotFound')
var args = ['--play-and-exit', '--video-on-top', '--no-video-title-show', '--quiet', `--meta-title=${title}`, url]
var args = ['--play-and-exit', '--video-on-top', '--quiet', `--meta-title=${JSON.stringify(title)}`, url]
spawnExternal(vlcPath, args)
})
}
@@ -41,7 +41,7 @@ function kill () {
function spawnExternal (path, args) {
log('Running external media player:', path + ' ' + args.join(' '))
proc = cp.spawn(path, args)
proc = cp.spawn(path, args, {stdio: 'ignore'})
// If it works, close the modal after a second
var closeModalTimeout = setTimeout(() =>