From 69a078ad4cace2e1bd2cd7dda987e3ae13b8213e Mon Sep 17 00:00:00 2001
From: Feross Aboukhadijeh <feross@feross.org>
Date: Sat, 5 Mar 2016 18:31:18 -0800
Subject: [PATCH] Header tweaks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This change does the following:

- Show the header on Linux/Windows when fullscreened, but not in the
player. Users might fullscreen the app when they’re not playing a video.
- Always show the header on OS X (even when fullscreened) since that’s
how the user will exit the video. We can work on adding auto-hiding to
it later.
---
 renderer/views/app.js | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/renderer/views/app.js b/renderer/views/app.js
index 56c93bb3..ae9aa38f 100644
--- a/renderer/views/app.js
+++ b/renderer/views/app.js
@@ -8,7 +8,23 @@ var Header = require('./header')
 var Player = require('./player')
 var TorrentList = require('./torrent-list')
 
+var isOSX = process.platform === 'darwin'
+
 function App (state, dispatch) {
+  return hx`
+    <div class='app'>
+      ${getHeader()}
+      <div class='content'>${getView()}</div>
+    </div>
+  `
+
+  function getHeader () {
+    // Hide the header on Windows/Linux when in the player
+    if (isOSX || state.url !== '/player') {
+      return Header(state, dispatch)
+    }
+  }
+
   function getView () {
     if (state.url === '/') {
       return TorrentList(state, dispatch)
@@ -16,18 +32,4 @@ function App (state, dispatch) {
       return Player(state, dispatch)
     }
   }
-
-  // Show the header only when we're outside of fullscreen
-  // Also don't show it in the video player except in OSX
-  var isOSX = process.platform === 'darwin'
-  var isVideo = state.url === '/player'
-  var isFullScreen = state.isFullScreen
-  var header = !isFullScreen && (!isVideo || isOSX) ? Header(state, dispatch) : null
-
-  return hx`
-    <div class="app">
-      ${header}
-      <div class="content">${getView()}</div>
-    </div>
-  `
 }