Fix playback bug: ensure openPlayer() always calls its callback

2016-04-06 02:05:27 -07:00
parent 464b41a435
commit 5e5d8799a7
2 changed files with 6 additions and 13 deletions
--- a/renderer/lib/location-history.js
+++ b/renderer/lib/location-history.js
@@ -18,9 +18,9 @@ LocationHistory.prototype._go = function (page) {
  if (page.onbeforeload) {
    this._pending = page
    page.onbeforeload((err) => {
-      if (err) return
      if (this._pending !== page) return /* navigation was cancelled */
      this._pending = null
+      if (err) return
      this._history.push(page)
    })
  } else {