From 8ee27b8ef45aa3f3d8c80cb2a4072ab7062dc22c Mon Sep 17 00:00:00 2001 From: Carey Metcalfe Date: Thu, 26 Sep 2019 20:49:17 -0400 Subject: [PATCH 1/5] Floor individual file percentages for display Fixes #1713 --- src/renderer/pages/torrent-list-page.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/pages/torrent-list-page.js b/src/renderer/pages/torrent-list-page.js index 5c4123ca..4e8ed5f4 100644 --- a/src/renderer/pages/torrent-list-page.js +++ b/src/renderer/pages/torrent-list-page.js @@ -316,7 +316,7 @@ module.exports = class TorrentList extends React.Component { torrentSummary.progress.files[index]) { const fileProg = torrentSummary.progress.files[index] isDone = fileProg.numPiecesPresent === fileProg.numPieces - progress = Math.round(100 * fileProg.numPiecesPresent / fileProg.numPieces) + '%' + progress = Math.floor(100 * fileProg.numPiecesPresent / fileProg.numPieces) + '%' } // Second, for media files where we saved our position, show how far we got From 8a235c31e0fe6c44d2ea3005de1cb781b37082fd Mon Sep 17 00:00:00 2001 From: Lucas <5874806+RecoX@users.noreply.github.com> Date: Tue, 1 Oct 2019 11:05:53 +1300 Subject: [PATCH 2/5] mono is needed to create setup.exe --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 51557b66..8a721366 100644 --- a/README.md +++ b/README.md @@ -149,6 +149,12 @@ install [XQuartz](http://www.xquartz.org/), then run: brew install wine ``` +Also to generate the .exe setup we need to install [Mono](https://www.mono-project.com/) + +``` +brew install mono +``` + (Requires the [Homebrew](http://brew.sh/) package manager.) #### Mac build notes @@ -164,7 +170,6 @@ If packaging from Mac, install system dependencies with Homebrew by running: ``` npm run install-system-deps ``` - #### Recommended readings to start working in the app Electron (Framework to make native apps for Windows, OSX and Linux in Javascript): From cb699b5fec235c25cfe96005955ea81c057ff8db Mon Sep 17 00:00:00 2001 From: Feross Aboukhadijeh Date: Mon, 30 Sep 2019 21:48:56 -0700 Subject: [PATCH 3/5] readme: clarify windows homebrew instructions --- README.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 8a721366..78099b83 100644 --- a/README.md +++ b/README.md @@ -142,17 +142,12 @@ The Windows app can be packaged from **any** platform. Note: Windows code signing only works from **Windows**, for now. Note: To package the Windows app from non-Windows platforms, -[Wine](https://www.winehq.org/) needs to be installed. For example on Mac, first -install [XQuartz](http://www.xquartz.org/), then run: +[Wine](https://www.winehq.org/) and [Mono](https://www.mono-project.com/) need +to be installed. For example on Mac, first install +[XQuartz](http://www.xquartz.org/), then run: ``` -brew install wine -``` - -Also to generate the .exe setup we need to install [Mono](https://www.mono-project.com/) - -``` -brew install mono +brew install wine mono ``` (Requires the [Homebrew](http://brew.sh/) package manager.) From 8fc7150559d60e472cab61996875e9be7a7824c1 Mon Sep 17 00:00:00 2001 From: Carey Metcalfe Date: Thu, 3 Oct 2019 02:22:12 -0400 Subject: [PATCH 4/5] Report when files are being verified When starting a torrent that is partially-downloaded, WebTorrent will now report "Verifying" as it verifies the existing data on disk. Fixes #1586 --- src/renderer/pages/torrent-list-page.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/renderer/pages/torrent-list-page.js b/src/renderer/pages/torrent-list-page.js index 4e8ed5f4..286e9acf 100644 --- a/src/renderer/pages/torrent-list-page.js +++ b/src/renderer/pages/torrent-list-page.js @@ -212,7 +212,9 @@ module.exports = class TorrentList extends React.Component { else if (torrentSummary.progress.progress === 1) status = 'Not seeding' else status = 'Paused' } else if (torrentSummary.status === 'downloading') { - status = 'Downloading' + if (!torrentSummary.progress) status = '' + else if (!torrentSummary.progress.ready) status = 'Verifying' + else status = 'Downloading' } else if (torrentSummary.status === 'seeding') { status = 'Seeding' } else { // torrentSummary.status is 'new' or something unexpected From 3fbf33b8ae1dd162da2b15a894ef3b0f195a42d7 Mon Sep 17 00:00:00 2001 From: Feross Aboukhadijeh Date: Sun, 6 Oct 2019 14:52:23 -0700 Subject: [PATCH 5/5] remove borewit from funding.yml (per his request) --- .github/FUNDING.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/FUNDING.yml b/.github/FUNDING.yml index d183cee9..27381237 100644 --- a/.github/FUNDING.yml +++ b/.github/FUNDING.yml @@ -1,2 +1 @@ github: feross -custom: https://paypal.me/borewit