From 3b6819f894864dd660879d3d4904e8359d6d9887 Mon Sep 17 00:00:00 2001 From: DC Date: Fri, 23 Sep 2016 01:15:51 -0700 Subject: [PATCH] Unmount audio/video tag when exiting player --- src/renderer/lib/errors.js | 5 ----- src/renderer/pages/player-page.js | 9 +++++++++ 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/renderer/lib/errors.js b/src/renderer/lib/errors.js index 4fbaefbf..80ca2688 100644 --- a/src/renderer/lib/errors.js +++ b/src/renderer/lib/errors.js @@ -17,10 +17,6 @@ class UnplayableFileError extends PlaybackError { constructor () { super('Can\'t play that file') } } -class PlaybackTimedOutError extends PlaybackError { - constructor () { super('Playback timed out. Try again.') } -} - /* Sound */ class InvalidSoundNameError extends SoundError { @@ -42,7 +38,6 @@ module.exports = { TorrentError, UnplayableTorrentError, UnplayableFileError, - PlaybackTimedOutError, InvalidSoundNameError, TorrentKeyNotFoundError, InvalidTorrentError diff --git a/src/renderer/pages/player-page.js b/src/renderer/pages/player-page.js index 23e65ca8..5e7032c6 100644 --- a/src/renderer/pages/player-page.js +++ b/src/renderer/pages/player-page.js @@ -26,6 +26,15 @@ module.exports = class Player extends React.Component { ) } + + onComponentWillUnmount () { + // Unload the media element so that Chromium stops trying to fetch data + const tag = document.querySelector('audio,video') + if (!tag) return + tag.pause() + tag.src = '' + tag.load() + } } // Handles volume change by wheel