fix(accessibility): Fix roles and add correct label for navigation controls (#2143)
* Accessibility: Fix roles and add correct label for navigation controls This makes screen readers properly indicate the control name, type, and state for the Back, Forward, and Add buttons. * Update src/renderer/components/header.js Co-authored-by: Alex <alxmorais8@msn.com>
This commit is contained in:
@@ -11,6 +11,7 @@ class Header extends React.Component {
|
|||||||
onMouseMove={dispatcher('mediaMouseMoved')}
|
onMouseMove={dispatcher('mediaMouseMoved')}
|
||||||
onMouseEnter={dispatcher('mediaControlsMouseEnter')}
|
onMouseEnter={dispatcher('mediaControlsMouseEnter')}
|
||||||
onMouseLeave={dispatcher('mediaControlsMouseLeave')}
|
onMouseLeave={dispatcher('mediaControlsMouseLeave')}
|
||||||
|
role='navigation'
|
||||||
>
|
>
|
||||||
{this.getTitle()}
|
{this.getTitle()}
|
||||||
<div className='nav left float-left'>
|
<div className='nav left float-left'>
|
||||||
@@ -18,6 +19,9 @@ class Header extends React.Component {
|
|||||||
className={'icon back ' + (loc.hasBack() ? '' : 'disabled')}
|
className={'icon back ' + (loc.hasBack() ? '' : 'disabled')}
|
||||||
title='Back'
|
title='Back'
|
||||||
onClick={dispatcher('back')}
|
onClick={dispatcher('back')}
|
||||||
|
role='button'
|
||||||
|
aria-disabled={!loc.hasBack()}
|
||||||
|
aria-label='Back'
|
||||||
>
|
>
|
||||||
chevron_left
|
chevron_left
|
||||||
</i>
|
</i>
|
||||||
@@ -25,6 +29,9 @@ class Header extends React.Component {
|
|||||||
className={'icon forward ' + (loc.hasForward() ? '' : 'disabled')}
|
className={'icon forward ' + (loc.hasForward() ? '' : 'disabled')}
|
||||||
title='Forward'
|
title='Forward'
|
||||||
onClick={dispatcher('forward')}
|
onClick={dispatcher('forward')}
|
||||||
|
role='button'
|
||||||
|
aria-disabled={!loc.hasForward()}
|
||||||
|
aria-label='Forward'
|
||||||
>
|
>
|
||||||
chevron_right
|
chevron_right
|
||||||
</i>
|
</i>
|
||||||
@@ -50,6 +57,7 @@ class Header extends React.Component {
|
|||||||
className='icon add'
|
className='icon add'
|
||||||
title='Add torrent'
|
title='Add torrent'
|
||||||
onClick={dispatcher('openFiles')}
|
onClick={dispatcher('openFiles')}
|
||||||
|
role='button'
|
||||||
>
|
>
|
||||||
add
|
add
|
||||||
</i>
|
</i>
|
||||||
|
|||||||
Reference in New Issue
Block a user