From 2b8fa8b6fe57bf1c6d29b60b57ac3c862eaf2c69 Mon Sep 17 00:00:00 2001
From: Julen Garcia Leunda
Date: Tue, 26 Nov 2019 16:59:10 +0100
Subject: [PATCH] fix review comments
---
src/main/windows/about.js | 7 ++++---
static/about.html | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/main/windows/about.js b/src/main/windows/about.js
index 335a437f..52c3a1c3 100644
--- a/src/main/windows/about.js
+++ b/src/main/windows/about.js
@@ -33,11 +33,12 @@ function init () {
win.loadURL(config.WINDOW_ABOUT)
- // No menu on the About window
- win.setMenu(null)
-
win.once('ready-to-show', function () {
win.show()
+ // No menu on the About window
+ // Hack: BrowserWindow removeMenu method not working on electron@7
+ // https://github.com/electron/electron/issues/21088
+ win.setMenuBarVisibility(false)
})
win.once('closed', function () {
diff --git a/static/about.html b/static/about.html
index c177b3c7..6433ae9c 100644
--- a/static/about.html
+++ b/static/about.html
@@ -34,6 +34,6 @@
()
()
-
+