From 24ac5af5b418edea43f7a9cc2c0f59d2a29a2c27 Mon Sep 17 00:00:00 2001 From: DC Date: Mon, 22 Aug 2016 00:20:15 -0700 Subject: [PATCH] Fix jumpToTime Fixes #801 --- src/renderer/controllers/playback-controller.js | 4 ++++ src/renderer/lib/cast.js | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/renderer/controllers/playback-controller.js b/src/renderer/controllers/playback-controller.js index c1781895..4bdadf76 100644 --- a/src/renderer/controllers/playback-controller.js +++ b/src/renderer/controllers/playback-controller.js @@ -93,6 +93,10 @@ module.exports = class PlaybackController { // Skip (aka seek) to a specific point, in seconds skipTo (time) { + if (!Number.isFinite(time)) { + console.error('Tried to skip to a non-finite time ' + time) + return console.trace() + } if (isCasting(this.state)) Cast.seek(time) else this.state.playing.jumpToTime = time } diff --git a/src/renderer/lib/cast.js b/src/renderer/lib/cast.js index 2bb8dc2c..180c833e 100644 --- a/src/renderer/lib/cast.js +++ b/src/renderer/lib/cast.js @@ -396,7 +396,9 @@ function stop () { function stoppedCasting () { state.playing.location = 'local' - state.playing.jumpToTime = state.playing.currentTime + state.playing.jumpToTime = Number.isFinite(state.playing.currentTime) + ? state.playing.currentTime + : 0 update() }