From f9d4e5e077c57810b50b9c15984ff6ce666dc222 Mon Sep 17 00:00:00 2001 From: Feross Aboukhadijeh Date: Tue, 31 May 2016 17:12:09 -0700 Subject: [PATCH] Use correct icon name https://github.com/feross/webtorrent-desktop/issues/467 The icon name is "closed_caption", not "closed_captions" http://jsbin.com/fenejob/1/edit?html,output The extra space we're seeing is the icon font rendering the 's', which renders as nothing. --- renderer/main.css | 9 +++------ renderer/views/player.js | 4 ++-- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/renderer/main.css b/renderer/main.css index 60be4af9..0ccc7705 100644 --- a/renderer/main.css +++ b/renderer/main.css @@ -715,10 +715,7 @@ body.drag .app::after { font-size: 22px; opacity: 0.85; - /* - * Fix for overflowing captions icon - * https://github.com/feross/webtorrent-desktop/issues/467 - */ + /* Make all icons have uniform spacing */ max-width: 23px; overflow: hidden; } @@ -754,7 +751,7 @@ body.drag .app::after { opacity: 0.8; } -.player .controls .icon.closed-captions { +.player .controls .icon.closed-caption { font-size: 26px; margin-top: 6px; } @@ -822,7 +819,7 @@ body.drag .app::after { transition-timing-function: ease-out; } -.player .controls .closed-captions.active, +.player .controls .closed-caption.active, .player .controls .device.active { color: #9af; } diff --git a/renderer/views/player.js b/renderer/views/player.js index e6fb35aa..a0a399ca 100644 --- a/renderer/views/player.js +++ b/renderer/views/player.js @@ -363,10 +363,10 @@ function renderPlayerControls (state) { if (state.playing.type === 'video') { // show closed captions icon elements.push(hx` - - closed_captions + closed_caption `) }