Merge pull request #616 from mchev/taxdecimal

Support 3-decimal tax percentages (e.g. 6.625%)

database/migrations/2026_04_07_000001_increase_tax_percent_precision_to_three_decimals.php

@@ -0,0 +1,30 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    public function up(): void
+    {
+        Schema::table('tax_types', function (Blueprint $table) {
+            $table->decimal('percent', 5, 3)->nullable()->change();
+        });
+
+        Schema::table('taxes', function (Blueprint $table) {
+            $table->decimal('percent', 5, 3)->nullable()->change();
+        });
+    }
+
+    public function down(): void
+    {
+        Schema::table('tax_types', function (Blueprint $table) {
+            $table->decimal('percent', 5, 2)->nullable()->change();
+        });
+
+        Schema::table('taxes', function (Blueprint $table) {
+            $table->decimal('percent', 5, 2)->nullable()->change();
+        });
+    }
+};

resources/scripts/admin/components/modal-components/TaxTypeModal.vue

@@ -58,15 +58,16 @@
             variant="horizontal"
             required
           >
-            <BaseMoney
+            <BaseInput
-              v-model="taxTypeStore.currentTaxType.percent"
+              :model-value="taxTypeStore.currentTaxType.percent"
-              :currency="{
+              type="number"
-                decimal: '.',
+              step="0.001"
-                thousands: ',',
+              min="-100"
-                symbol: '% ',
+              max="100"
-                precision: 2,
+              inline-addon="%"
-                masked: false,
+              :invalid="v$.currentTaxType.percent.$error"
-              }"
+              @update:model-value="onTaxPercentInput"
+              @blur="onTaxPercentBlur"
             />
           </BaseInputGroup>
 
@@ -207,7 +208,38 @@ const v$ = useVuelidate(
   computed(() => taxTypeStore)
 )
 
+function onTaxPercentInput(val) {
+  v$.value.currentTaxType.percent.$touch()
+
+  if (val === '' || val === null) {
+    taxTypeStore.currentTaxType.percent = null
+
+    return
+  }
+
+  const n = typeof val === 'number' ? val : parseFloat(val)
+  taxTypeStore.currentTaxType.percent = Number.isNaN(n) ? null : n
+}
+
+function onTaxPercentBlur() {
+  const p = taxTypeStore.currentTaxType.percent
+  if (p === null || p === undefined || p === '') {
+    return
+  }
+
+  const n = typeof p === 'number' ? p : parseFloat(p)
+  if (Number.isNaN(n)) {
+    return
+  }
+
+  taxTypeStore.currentTaxType.percent = Math.round(n * 1000) / 1000
+}
+
 async function submitTaxTypeData() {
+  if (taxTypeStore.currentTaxType.calculation_type === 'percentage') {
+    onTaxPercentBlur()
+  }
+
   v$.value.currentTaxType.$touch()
   if (v$.value.currentTaxType.$invalid) {
     return true

resources/scripts/admin/views/settings/TaxTypesSetting.vue

@@ -248,4 +248,5 @@ function openTaxModal() {
     refreshData: table.value && table.value.refresh,
   })
 }
+
 </script>

tests/Feature/Admin/TaxTypeTest.php

@@ -5,6 +5,7 @@ use App\Http\Requests\TaxTypeRequest;
 use App\Models\TaxType;
 use App\Models\User;
 use Illuminate\Support\Facades\Artisan;
+use Illuminate\Support\Facades\DB;
 use Laravel\Sanctum\Sanctum;
 
 use function Pest\Laravel\deleteJson;
@@ -110,3 +111,22 @@ test('create fixed amount tax type', function () {
 
     $this->assertDatabaseHas('tax_types', $taxType);
 });
+
+test('create percentage tax type with three decimals', function () {
+    $payload = TaxType::factory()->raw([
+        'calculation_type' => 'percentage',
+        'percent' => 6.625,
+        'fixed_amount' => null,
+    ]);
+
+    $response = postJson('api/v1/tax-types', $payload)
+        ->assertStatus(201);
+
+    $taxTypeId = $response->json('data.id');
+
+    expect($taxTypeId)->not()->toBeNull();
+
+    $rawPercent = DB::table('tax_types')->where('id', $taxTypeId)->value('percent');
+
+    expect((string) $rawPercent)->toBe('6.625');
+});